Skip to content

[RL] Add rank-local IPC weight updates - #52497

Open
aoshen02 wants to merge 3 commits into
vllm-project:mainfrom
aoshen02:codex/ipc-target-gpu-routing
Open

[RL] Add rank-local IPC weight updates#52497
aoshen02 wants to merge 3 commits into
vllm-project:mainfrom
aoshen02:codex/ipc-target-gpu-routing

Conversation

@aoshen02

Copy link
Copy Markdown
Collaborator

Motivation

MoE training ranks may own different expert parameters from rollout workers. A weight-update request therefore needs different IPC metadata for each rollout worker rank without broadcasting every expert to every worker.

Design

  • Keep update_info: a dictionary is shared; a list is indexed by worker rank; None skips that worker.
  • Select the local entry in GPUWorker, then call the existing transfer engine unchanged.
  • Extend HTTP serialization to encode CUDA IPC handles inside list entries.

This matches SGLang's rank-indexed payload model. It adds no backend capability flag, request type, transport engine branch, or new endpoint.

Validation

  • Changed-file pre-commit suite passes, including Ruff, formatting, Markdownlint, and Python 3.10 mypy.
  • Focused trainer-client tests: 6 passed.
  • Two-host GPU crossover A/B passed with Qwen3-30B-A3B on 8 H200 GPUs per run.

Performance

With the same image, model, BF16 rollout, DeepEP topology, and two training
steps, baseline IPC updates averaged 8.753 s and rank-local updates averaged
3.889 s: 2.25x faster and 55.6% lower latency. Swapping baseline and
candidate between h200-0 and h200-1 reproduced the result on both hosts.

AI assistance

Developed with OpenAI Codex assistance; human review is required before merge.

Co-authored-by: OpenAI Codex <noreply@openai.com>
Signed-off-by: aoshen02 <aoshen@inferact.ai>
@mergify

mergify Bot commented Aug 16, 2026

Copy link
Copy Markdown
Contributor

Documentation preview: https://vllm--52497.org.readthedocs.build/en/52497/

@mergify mergify Bot added the documentation Improvements or additions to documentation label Aug 16, 2026
@aoshen02 aoshen02 added the ready ONLY add when PR is ready to merge/full CI is needed label Aug 16, 2026
@aoshen02
aoshen02 marked this pull request as ready for review August 16, 2026 06:22
@aoshen02
aoshen02 requested a review from njhill as a code owner August 16, 2026 06:22

@claude claude Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Claude Code Review

This pull request is from a fork — automated review is disabled. A repository maintainer can comment @claude review to run a one-time review.

@aoshen02

Copy link
Copy Markdown
Collaborator Author

/ci run

@github-actions

Copy link
Copy Markdown

✅ Triggered Buildkite CI #84070 for commit 0a1f4bd668fb.

@mergify

mergify Bot commented Aug 16, 2026

Copy link
Copy Markdown
Contributor

Hi @aoshen02, the pre-commit checks have failed. Please run:

uv pip install pre-commit>=4.5.1
pre-commit install
pre-commit run --all-files

Then, commit the changes and push to your branch.

For future commits, pre-commit will run automatically on changed files before each commit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation ready ONLY add when PR is ready to merge/full CI is needed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant