[hw-agnostic] Adding embedding layer and lm_head - #52355
Open
bohnstingl wants to merge 1 commit into
Open
Conversation
Signed-off-by: Thomas Ortner <boh@zurich.ibm.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Extends the hardware-agnostic layer path in the Transformers modeling backend to
cover the token-embedding boundary: input embedding (
VocabParallelEmbedding),LM head (
ParallelLMHead), and the logits projection (LogitsProcessor).When
VLLM_USE_HW_AGNOSTICis unset (the default), behavior is unchanged: everysite resolves to the same vLLM class it used before.
Test Plan
I ran an
lm_evalwith the Granite3.3-8B model, to demonstrate that the new additional layers do not introduce numerical issues.In addition, I also added some new, specific tests for the layers.
Test Result
lm_eval results:
Essential Elements of an Effective PR Description Checklist
supported_models.mdandexamplesfor a new model.cc @tdoublep @hmellor @zou3519