[CI] Shard multimodal standard 4 tests - #52338
Draft
khluu wants to merge 3 commits into
Draft
Conversation
Signed-off-by: Kevin Luu <51931015+khluu@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
multi-modal-models-standard-4-other-whisperas four deterministic shardsWhy
Buildkite build #83851 took 50.857 minutes for this job, including 49.171 minutes across its four pytest commands and 1.687 minutes of outer fixed cost. Four shards target less than 20 minutes with headroom for model imbalance.
The AMD parallelism override depends on ci-infra #473. This PR must not merge first.
Current-main blocker
Targeted Buildkite #83935 is rejected for acceptance. The isolated
test_vit_cudagraph_image[gemma4]process loaded the model and compiled its graph, then repeatedly failed 249,561,088-byte allocations with only 160/94/28 MiB free on the 33,280-MiB device. It ended in the same PyTorchNVML_SUCCESS == rallocator assertion seen in the earlier sharded attempts. Because the image and video commands are intentionally joined with&&, the image failure prevented the independently isolated video node from executing in this run.The build is also a false green under this draft command shape. All four jobs finished with exit status 0 and 13.461/7.940/10.397/8.088-minute walls even though shard 0 contains the failed pytest. The failing image command is the left side of an AND-list, so shell
-edoes not stop there; the generated command continued through the remaining test commands and returned the last successful status. The green Buildkite state therefore is not valid acceptance evidence.This is a current-main resource regression rather than a sharding defect or smaller worker allocation:
PYTORCH_CUDA_ALLOC_CONF=expandable_segments:False, and the same 18.92-GiB post-load KV-cache figure for Gemma4h200-ci-4-12GPU 2 slot 3, while #83935 usedh200-ci-4-15GPU 3 slot 2v0.27.2rc1.dev78+g8e6d8e4f6and passed its 20-node vit command; current #83935 ranv0.27.2rc1.dev92+g27f27c53066728fe, “Enable encoder cuda graph for model runner v2,” which changes the encoder-cudagraph path this exact test exercisesKeep this PR draft and do not skip, xfail, or change the resource semantics. It is not ready for the accepted set until current main can run the underlying Gemma4 case on the existing worker allocation.
Validation
.buildkite/test_areas/models_multimodal.yamlwith PyYAMLuvx pre-commit run --files .buildkite/test_areas/models_multimodal.yamlgit diff --checksrcIndex < srcSelectDimSizefailed. #473 heade006ba64b39ffd4f179824f088ff10e88af5635f; verified NVIDIA parallelism 4, AMD parallelism 1, three deterministic sharded commands, Gemma4 coverage 2/2 as separate one-node processes, singleton memory-leak coverage 1/1 exactly once, fail-closed unexpected-index handling, and dependency preservation&&1 failedfor the isolated image-Gemma command; this terminal false-green result is explicitly rejectedsrcIndex < srcSelectDimSizefailed. #473 render preserve the intended exact 2 Gemma4 + 18 complementary vit IDs without skips, xfails, retries, or duplicationDuplicate-work check
Searched open PRs by the exact step key and sharding keywords. No open PR shards this job; source-dependency and ROCm-gating changes are unrelated.
AI assistance was used to prepare and validate this CI-only change.