Skip to content

[model] feat: add qwen3-122b long seq launch script for ascend#6807

Merged
wucong25 merged 2 commits into
verl-project:mainfrom
zjchenn:model/qwen3-5-long-seq
Jun 22, 2026
Merged

[model] feat: add qwen3-122b long seq launch script for ascend#6807
wucong25 merged 2 commits into
verl-project:mainfrom
zjchenn:model/qwen3-5-long-seq

Conversation

@zjchenn

@zjchenn zjchenn commented Jun 22, 2026

Copy link
Copy Markdown
Contributor

What does this PR do?

Add the Ascend Megatron GRPO script for Qwen3.5-122B-A10B long-sequence training.

Checklist Before Starting

  • Search for similar PRs. Paste at least one query link here: ...
  • Format the PR title as [{modules}] {type}: {description} (This will be checked by the CI)
    • {modules} include fsdp, megatron, veomni, sglang, vllm, rollout, trainer, ci, training_utils, recipe, hardware, deployment, ray, worker, single_controller, misc, perf, model, algo, env, tool, ckpt, doc, data, cfg, reward, fully_async, one_step_off
    • If this PR involves multiple modules, separate them with , like [megatron, fsdp, doc]
    • {type} is in feat, fix, refactor, chore, test
    • If this PR breaks any API (CLI arguments, config, function signature, etc.), add [BREAKING] to the beginning of the title.
    • Example: [BREAKING][fsdp, megatron] feat: dynamic batching

Test

For changes that can not be tested by CI (e.g., algorithm implementation, new model support), validate by experiment(s) and show results like training curve plots, evaluation results, etc.

API and Usage Example

Demonstrate how the API changes if any, and provide usage example(s) if possible.

# Add code snippet or script demonstrating how to use this

Design & Code Changes

Demonstrate the high-level design if this PR is complex, and list the specific changes.

Checklist Before Submitting

Important

Please check all the following items before requesting a review, otherwise the reviewer might deprioritize this PR for review.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a new launch script for running GRPO training with Qwen3.5-122B using Megatron and vLLM on Ascend NPUs. A critical issue was identified where the undefined variable NDEVICES_PER_NODE is referenced, which will cause the script to crash immediately due to the set -u option. It is recommended to replace it with the defined NPUS_PER_NODE variable.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

trainer.logger='["console"]'
trainer.project_name=${project_name}
trainer.experiment_name=${exp_name}
trainer.n_gpus_per_node=${NDEVICES_PER_NODE}

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

The variable NDEVICES_PER_NODE is not defined in this script. Since set -u is enabled, referencing an unbound variable will cause the script to crash immediately upon execution. It should be replaced with NPUS_PER_NODE which is defined on line 17.

Suggested change
trainer.n_gpus_per_node=${NDEVICES_PER_NODE}
trainer.n_gpus_per_node=${NPUS_PER_NODE}
References
  1. Enable set -xeuo pipefail in shell scripts to ensure that the script exits on errors, treats unset variables as errors, and pipelines fail correctly.

Co-authored-by: zhouhengan1211 <zhouhengan1211@gmail.com>
Signed-off-by: zjchenn <zjchenn@gmail.com>
@zjchenn zjchenn force-pushed the model/qwen3-5-long-seq branch from b495e51 to f0ea249 Compare June 22, 2026 02:14
@wucong25 wucong25 merged commit 3576250 into verl-project:main Jun 22, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants