Skip to content

[fully_async] fix: remove invalid rollout.single_turn_response_length override#6795

Closed
Vivicai1005 wants to merge 1 commit into
verl-project:mainfrom
Vivicai1005:fix/rollout-single-turn-response-length
Closed

[fully_async] fix: remove invalid rollout.single_turn_response_length override#6795
Vivicai1005 wants to merge 1 commit into
verl-project:mainfrom
Vivicai1005:fix/rollout-single-turn-response-length

Conversation

@Vivicai1005

Copy link
Copy Markdown
Contributor

What does this PR do?

Removes an invalid Hydra override from the Qwen3.5-35B-A3B fully-async GRPO example script. The line set actor_rollout_ref.rollout.single_turn_response_length, but this key does not exist in RolloutConfig

Checklist Before Starting

  • Search for similar PRs. Paste at least one query link here: https://github.com/verl-project/verl/pulls?q=is%3Apr+single_turn_response_length
  • Format the PR title as [{modules}] {type}: {description} (This will be checked by the CI)
    • {modules} include fsdp, megatron, veomni, sglang, vllm, rollout, trainer, ci, training_utils, recipe, hardware, deployment, ray, worker, single_controller, misc, perf, model, algo, env, tool, ckpt, doc, data, cfg, reward, fully_async, one_step_off
    • If this PR involves multiple modules, separate them with , like [megatron, fsdp, doc]
    • {type} is in feat, fix, refactor, chore, test
    • If this PR breaks any API (CLI arguments, config, function signature, etc.), add [BREAKING] to the beginning of the title.
    • Example: [BREAKING][fsdp, megatron] feat: dynamic batching

Test

No functional code path changes — this only removes a config override that prevented the example script from launching

Checklist Before Submitting

Important

Please check all the following items before requesting a review, otherwise the reviewer might deprioritize this PR for review.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request removes the 'actor_rollout_ref.rollout.single_turn_response_length' configuration parameter from the 'grpo_qwen35_35b_megatron_async.sh' shell script. There are no review comments, and I have no feedback to provide.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

@wuxibin89

Copy link
Copy Markdown
Collaborator

@Vivicai1005 The verl/experimental/fully_async_policy is in maintenance mode, we encourage user to use new V1 trainer:

trainer.use_v1=True
trainer.v1.trainer_mode=colocate_async # sync/colocate_async/separate_async

@wuxibin89 wuxibin89 closed this Jun 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants