[WIP][ci] chore: change two-node Ascend RayJob E2E workflow from A2 to A3#6787
[WIP][ci] chore: change two-node Ascend RayJob E2E workflow from A2 to A3#6787wangdongleix wants to merge 1 commit into
Conversation
There was a problem hiding this comment.
Code Review
This pull request updates the number of GPUs per node from 4 to 8 in the multinode PPO training script for Qwen3. The reviewer noted that the experiment name still references the old 2x4 configuration and suggested updating it to reflect the new 2x8 setup for consistency.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
| trainer.project_name='verl_ppo_example_gsm8k_qwen3' \ | ||
| trainer.experiment_name='qwen3_06b_fsdp_multinode_2x4' \ | ||
| trainer.n_gpus_per_node=4 \ | ||
| trainer.n_gpus_per_node=8 \ |
There was a problem hiding this comment.
The number of GPUs per node has been increased to 8, which changes the setup to a 2x8 multinode configuration. However, trainer.experiment_name on line 52 is still set to 'qwen3_06b_fsdp_multinode_2x4'. Please update the experiment name to reflect the new 2x8 configuration (e.g., 'qwen3_06b_fsdp_multinode_2x8') to ensure consistent and accurate experiment tracking.
6093ada to
65ed71c
Compare
|
wangdonglei seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
What does this PR do?
Checklist Before Starting
[{modules}] {type}: {description}(This will be checked by the CI){modules}includefsdp,megatron,veomni,sglang,vllm,rollout,trainer,ci,training_utils,recipe,hardware,deployment,ray,worker,single_controller,misc,perf,model,algo,env,tool,ckpt,doc,data,cfg,reward,fully_async,one_step_off,like[megatron, fsdp, doc]{type}is infeat,fix,refactor,chore,test[BREAKING]to the beginning of the title.[BREAKING][fsdp, megatron] feat: dynamic batchingTest
API and Usage Example
# Add code snippet or script demonstrating how to use thisDesign & Code Changes
Checklist Before Submitting
Important
Please check all the following items before requesting a review, otherwise the reviewer might deprioritize this PR for review.
pre-commit install && pre-commit run --all-files --show-diff-on-failure --color=alwaysci-requestchannel in theverlSlack workspace. (If not accessible, please try the Feishu group (飞书群).)recipesubmodule, please also update the reference to the submodule commit viagit submodule update --remoteorcd recipe && git pull origin main.