Skip to content

[WIP][ci] chore: change two-node Ascend RayJob E2E workflow from A2 to A3#6787

Open
wangdongleix wants to merge 1 commit into
verl-project:mainfrom
wangdongleix:main
Open

[WIP][ci] chore: change two-node Ascend RayJob E2E workflow from A2 to A3#6787
wangdongleix wants to merge 1 commit into
verl-project:mainfrom
wangdongleix:main

Conversation

@wangdongleix

Copy link
Copy Markdown
Contributor

What does this PR do?

Add concise overview of what this PR aims to achieve or accomplish. Reference related GitHub issues and PRs that help with the review.

Checklist Before Starting

  • Search for similar PRs. Paste at least one query link here: ...
  • Format the PR title as [{modules}] {type}: {description} (This will be checked by the CI)
    • {modules} include fsdp, megatron, veomni, sglang, vllm, rollout, trainer, ci, training_utils, recipe, hardware, deployment, ray, worker, single_controller, misc, perf, model, algo, env, tool, ckpt, doc, data, cfg, reward, fully_async, one_step_off
    • If this PR involves multiple modules, separate them with , like [megatron, fsdp, doc]
    • {type} is in feat, fix, refactor, chore, test
    • If this PR breaks any API (CLI arguments, config, function signature, etc.), add [BREAKING] to the beginning of the title.
    • Example: [BREAKING][fsdp, megatron] feat: dynamic batching

Test

For changes that can not be tested by CI (e.g., algorithm implementation, new model support), validate by experiment(s) and show results like training curve plots, evaluation results, etc.

API and Usage Example

Demonstrate how the API changes if any, and provide usage example(s) if possible.

# Add code snippet or script demonstrating how to use this

Design & Code Changes

Demonstrate the high-level design if this PR is complex, and list the specific changes.

Checklist Before Submitting

Important

Please check all the following items before requesting a review, otherwise the reviewer might deprioritize this PR for review.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the number of GPUs per node from 4 to 8 in the multinode PPO training script for Qwen3. The reviewer noted that the experiment name still references the old 2x4 configuration and suggested updating it to reflect the new 2x8 setup for consistency.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

trainer.project_name='verl_ppo_example_gsm8k_qwen3' \
trainer.experiment_name='qwen3_06b_fsdp_multinode_2x4' \
trainer.n_gpus_per_node=4 \
trainer.n_gpus_per_node=8 \

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

The number of GPUs per node has been increased to 8, which changes the setup to a 2x8 multinode configuration. However, trainer.experiment_name on line 52 is still set to 'qwen3_06b_fsdp_multinode_2x4'. Please update the experiment name to reflect the new 2x8 configuration (e.g., 'qwen3_06b_fsdp_multinode_2x8') to ensure consistent and accurate experiment tracking.

@wangdongleix wangdongleix force-pushed the main branch 2 times, most recently from 6093ada to 65ed71c Compare June 18, 2026 08:10
@CLAassistant

Copy link
Copy Markdown

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


wangdonglei seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants