Fix device code flow parsing (stdout + URL mismatch) - #94
Merged
Conversation
raketforskaren
commented
Apr 8, 2026
raketforskaren
commented
- Fix Azure CLI output parsing by reading from stdout instead of stderr
- Update URL regex to support new Azure endpoint (login.microsoft.com/device)
- Improves reliability of device code flow authentication technique
openrec0n
added
bug
Collaborator
|
@raketforskaren The PR description claims to "Update URL regex to support new Azure endpoint (login.microsoft.com/device)", but no regex change is present in the diff. |
Fix comment that still referenced stderr after switching to stdout. Update URL regex in both parsing locations to match the new Azure endpoint (login.microsoft.com/device) in addition to the legacy microsoft.com/devicelogin URL.
openrec0n
approved these changes
Apr 8, 2026
Author
@openrec0n Thanks for catching the mismatch and fixing it. The PR description was stale and didn’t reflect the actual diff. I should have cleaned that up before sending it for review. |
Collaborator
nw! Thanks for noticing the bug and PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.