chore: migrate supported runtime to Node 24 - #1561
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: ⛔ Files ignored due to path filters (2)
📒 Files selected for processing (4)
🚧 Files skipped from review as they are similar to previous changes (2)
📝 WalkthroughWalkthroughThe project now requires Node.js 24. Docker images, local Compose services, and GitHub Actions workflows use Node.js 24.19.0. The Kaneo runtime also updates its Nginx constraint, and ChangesNode.js 24 upgrade
Estimated code review effort: 1 (Trivial) | ~5 minutes Merge Risk: ⚪ Minimal · up to This change updates the supported Node.js runtime and related build environments, with tests, typechecking, and production image builds reported as passing; no actionable merge-blocking risk remains. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
PR Summary by Qodochore: migrate supported runtime to Node.js 24.19.0
AI Description
Diagram
High-Level Assessment
Files changed (11)
|
Code Review by Qodo🐞 Bugs (0) 📘 Rule violations (0) 📎 Requirement gaps (0)
Great, no issues found!Qodo reviewed your code and found no material issues that require reviewTip of the day💡 Did you know, you can group findings by type and pick your Finding display, from Minimal to Full |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@package.json`:
- Line 31: Add an explicit engines.node requirement to the MCP package manifest
in packages/mcp/package.json, using the same Node.js version constraint defined
by the root package.json. Keep the published MCP runtime prerequisite aligned
with that shared value.
🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro Plus
Run ID: ad5cebde-7dc0-4462-8ff3-942fbd914d44
⛔ Files ignored due to path filters (1)
CONTRIBUTING.mdis excluded by!**/*.md
📒 Files selected for processing (10)
.dockerignore.github/workflows/ci.yml.github/workflows/deploy-site.yml.github/workflows/nightly.yml.github/workflows/publish-mcp.ymlDockerfile.kaneoapps/api/Dockerfileapps/web/Dockerfilecompose.local.ymlpackage.json
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: e9a57f626c
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
e9a57f6 to
ee03ea9
Compare
|
@N1arko thank you for your work on this. I took a look with some of the security tools we have (socket, trivy, etc) and it looks like this should be good to ship. As long as CI continues to pass, we are good to move the dep up @andrejsshell and @tinsever |
Description
Move Kaneo's supported development, CI, and container runtime from Node.js 20 to the current Node.js 24 LTS line.
Node.js 20 is now end-of-life, while Node.js 24 is an actively supported LTS release. This PR pins Node.js 24.19.0 across GitHub Actions, the combined production image, the standalone API and web images, local docs tooling, package engines, and contributor documentation.
The combined Alpine image also moves to nginx 1.30.4, which is the version available in the Node 24.19.0 Alpine base. A root
.dockerignorekeeps local dependencies, build outputs, Git metadata, environment files, and logs out of every Docker build context.Node.js release status: https://nodejs.org/en/about/previous-releases
Type of Change
How Has This Been Tested?
Validation:
pnpm install --frozen-lockfilepnpm test(88 test files, 458 tests passed)pnpm typecheckDockerfile.kaneobuild.dockerignoreChecklist
Additional Notes
The minimum Node.js engine is now 24. Existing deployments based on the published Kaneo image receive the runtime through the image and do not need a host-level Node.js installation.
Summary by CodeRabbit