Studio: share GGUF recommendation policy across pickers - #7733
Open
ousamabenyounes wants to merge 2 commits into
Open
Studio: share GGUF recommendation policy across pickers#7733ousamabenyounes wants to merge 2 commits into
ousamabenyounes wants to merge 2 commits into
Conversation
6 tasks
Contributor
Author
|
Updated the patch to share only the recommendation policy while preserving each picker’s existing fit thresholds. Added the downloaded-fit versus OOM regression case, fully structural chat-picker integration coverage, 100% helper branch coverage, and Chromium checks for both surfaces. Local validation: 10/10 focused tests, 194/194 full frontend tests, typecheck, and production build. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #7646
Test verification (RED → GREEN)
RED on the previous PR implementation: a downloaded fitting
Q4_K_Mwas skipped and the remaining OOMQ8_0was incorrectly recommended:GREEN after the patch:
The chat-picker integration test parses the executable TSX AST. An adversarial run with the expected expression present only in a comment fails, while the restored executable predicate passes.
AI assistance disclosure
This contribution was assisted by OpenAI Codex. I reviewed and understood the final patch and verified it with automated tests and Chromium.