Skip to content

fix(http): merge default options when partial opts are provided #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pi0 merged 2 commits into from
Mar 19, 2026
Merged

fix(http): merge default options when partial opts are provided #2

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4888786
fix(http): merge default options when partial opts are provided
oritwoen Mar 10, 2026
7e5e534
chore: apply automated updates
autofix-ci[bot] Mar 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion src/http.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,8 +32,10 @@ function defaultCacheOptions() {
*/
export function defineCachedHandler<E extends HTTPEvent = HTTPEvent>(
handler: EventHandler<E>,
opts: CachedEventHandlerOptions<E> = defaultCacheOptions() as CachedEventHandlerOptions<E>,
opts: CachedEventHandlerOptions<E> = {},
): EventHandler<E> {
opts = { ...defaultCacheOptions(), ...opts };

const variableHeaderNames = (opts.varies || [])
.filter(Boolean)
.map((h) => h.toLowerCase())
Expand Down
10 changes: 10 additions & 0 deletions test/index.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -780,6 +780,16 @@ describe("defineCachedHandler", () => {
expect(res.status).toBe(200);
});

it("merges default options when partial opts are provided", async () => {
const path = uniquePath();
const handler = defineCachedHandler(() => new Response("ok"), { maxAge: 60 });

const res = (await handler(makeEvent(path))) as Response;
const cc = res.headers.get("cache-control")!;
expect(cc).toContain("s-maxage=60");
expect(cc).toContain("stale-while-revalidate");
});

it("works with generic event type", async () => {
interface CustomEvent extends HTTPEvent {
custom: string;
Expand Down
Loading