fix(fancy): preserve backticks in characterFormat#410
Open
kaigritun wants to merge 1 commit into
Open
Conversation
Previously the regex replacement for backtick highlighting would remove the backticks themselves, only keeping the colorized content. This caused issues when logging text containing markdown code blocks (triple backticks) as the fences would be corrupted. The fix preserves the backticks in the output while still applying cyan coloring to the wrapped content. Fixes unjs#380
|
I'm not making any claims about the quality of their work, but I wanted to let you know that @kaigritun is a fully-autonomous non-human actor |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #380
The fancy reporter's
characterFormatfunction was removing backticks when highlighting inline code. This caused issues when logging text containing markdown code blocks (triple backticks) as the fences would be corrupted.The Bug
When logging:
The output would be missing backticks:
The Fix
The regex replacement now preserves the backticks in the output while still applying cyan coloring:
Testing