Skip to content

[SAST] Fix several handle leaks #2764

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Canned-pineapple-8 wants to merge 2 commits into
base: master
Choose a base branch
from
+7 −0
Open

[SAST] Fix several handle leaks #2764

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bcba951
Fix(plugins): close plugin_handle on dlsym() failure
Canned-pineapple-8 May 6, 2026
608adf7
Fix(socket): close serverfd on several error paths after uwsgi_nuclea…
Canned-pineapple-8 May 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions core/plugins.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -270,6 +270,9 @@ void *uwsgi_load_plugin(int modifier, char *plugin, char *has_option) {
free(plugin_name);
if (plugin_filename)
free(plugin_filename);
if (plugin_handle && dlclose(plugin_handle)) {
uwsgi_error("dlclose()");
}

return NULL;
}
Expand Down
4 changes: 4 additions & 0 deletions core/socket.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,6 +94,7 @@ static int create_server_socket(int domain, int type) {
if (setsockopt(serverfd, SOL_SOCKET, SO_REUSEADDR, (const void *) &reuse, sizeof(int)) < 0) {
uwsgi_error("SO_REUSEADDR setsockopt()");
uwsgi_nuclear_blast();
close(serverfd);
return -1;
}
}
Expand All @@ -104,6 +105,7 @@ static int create_server_socket(int domain, int type) {
if (setsockopt(serverfd, SOL_SOCKET, SO_SNDBUF, &sndbuf, sizeof(socklen_t)) < 0) {
uwsgi_error("SO_SNDBUF setsockopt()");
uwsgi_nuclear_blast();
close(serverfd);
return -1;
}
else {
Expand All @@ -116,6 +118,7 @@ static int create_server_socket(int domain, int type) {
if (setsockopt(serverfd, SOL_SOCKET, SO_RCVBUF, &rcvbuf, sizeof(socklen_t)) < 0) {
uwsgi_error("SO_RCVBUF setsockopt()");
uwsgi_nuclear_blast();
close(serverfd);
return -1;
}
else {
Expand All @@ -128,6 +131,7 @@ static int create_server_socket(int domain, int type) {
if (somaxconn > 0 && uwsgi.listen_queue > somaxconn) {
uwsgi_log("Listen queue size is greater than the system max net.core.somaxconn (%li).\n", somaxconn);
uwsgi_nuclear_blast();
close(serverfd);
return -1;
}
#endif
Expand Down