[SAST] Fix multiple handle leaks#2763
Closed
Canned-pineapple-8 wants to merge 2 commits into
Closed
Conversation
Plugin handle acquired via dlopen() is not closed if both dlsym() calls fail. Add dlclose() to the cleanup block before returning. Fixes handle leak found by Svace static analyzer
…r_blast() Socket descriptor serverfd may leak if uwsgi_nuclear_blast() returns (e.g., when running as Emperor) instead of terminating the process. Close the descriptor in this case. Fixes handle leak found by Svace static analyzer
Canned-pineapple-8
changed the title
Author
|
Closed in favor of #2764 (branch was renamed). Sorry for the mess... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes 2 handle leaks found by Svace static analyzer. See issue #2762 for details.
Commits:
fix(socket): close serverfd after uwsgi_nuclear_blast()fix(plugins): close plugin_handle on dlsym() failureCloses #2762
If any fix is incorrect, please comment on the specific commit. I will update the PR accordingly.