Skip to content

Add support for Float and Fixed overflow when last data is NullData#107

Open
Hinogary wants to merge 10 commits into
u9n:masterfrom
Hinogary:master
Open

Add support for Float and Fixed overflow when last data is NullData#107
Hinogary wants to merge 10 commits into
u9n:masterfrom
Hinogary:master

Conversation

@Hinogary

@Hinogary Hinogary commented Sep 8, 2025

Copy link
Copy Markdown

No description provided.

@Krolken

Krolken commented Sep 8, 2025

Copy link
Copy Markdown
Contributor

Nice. Open an issue about this and explain a bit more what you are trying to solve. I'm not sure this is how I would like the solution to be.

Good catch with the pointer.

@Hinogary

Copy link
Copy Markdown
Author

I’m trying to read new data types like Float or BitString. I’m not sure if this description belongs in a separate issue. Let’s rather discuss it directly over the code.

I think you have issue with VARIABLE_LENGTH_BITS? I dont know how to do it differently. it is not VARIABLE_LENGTH, because length is in bits not bytes, also can't be 0 or any specific number, because it is variable. Or you have issue with some other code? Feel free to comment specific line of code.

@Krolken

Krolken commented Sep 14, 2025

Copy link
Copy Markdown
Contributor

I was under the impression that BITSTRING length was still in octets.
A length byte for how many octets, then a byte representing unused bits in the last octet and then the octets.

What object are you trying to model?

@Hinogary

Copy link
Copy Markdown
Author

I come to conclussion that i dont need bitstring. I tried to read status of Image transfer, but meter i am using have segmented display, so this will not be used anyway. https://www.gurux.fi/Gurux.DLMS.Objects.GXDLMSImageTransfer
I will remove changes with it once i got home.

@Hinogary Hinogary changed the title Add support for Float and BitString and Fixed overflow when last data is NullData Add support for Float and Fixed overflow when last data is NullData Sep 16, 2025
@Hinogary

Copy link
Copy Markdown
Author

You are probably right, that BitString is still in Octets, my bad.

I removed it, is it now ok?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants