-
-
Notifications
You must be signed in to change notification settings - Fork 14
Add Mode and Scale types with complete WASM bindings. #31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
42 commits
Select commit
Hold shift + click to select a range
e089614
Initial plan
Copilot cd6b149
Implement core Mode and Scale types with explicit intervals
Copilot dd90f8a
Add Scale and Mode documentation examples to lib.rs
Copilot fc06344
Deduplicate HasRoot trait - use existing trait from chord.rs
Copilot 63de454
Add parsing support for Mode and Scale from text strings
Copilot bb98fd0
Add harmonic minor and melodic minor modes with full parsing support
Copilot 2b85ea1
Add scale/mode candidates enumeration to chord descriptions
Copilot 4920a0f
Add MajorPentatonic, MinorPentatonic, and Blues scales with full pars…
Copilot 4b60389
Add scale/mode notes in parentheses to chord display recommendations
Copilot b59a42e
Enforce correct enharmonic spelling with validation and fix interval …
Copilot 961962e
Change Blues scale to use ♯4 instead of ♭5 for blue note
Copilot 7b6343a
Add comprehensive golden tests for enharmonic spelling and chord-to-c…
Copilot 43cf1a3
Merge pull request #33 from twitchax/main
twitchax ec2f7bb
Enforce separation of concerns: remove scale/mode info from descripti…
Copilot a16810b
Refactor scale candidate storage to use static storage per KnownChord
Copilot e8ab3bc
Remove backup files
Copilot 5d300ce
Address PR review comments: add helper method, move imports to top, f…
Copilot f045c2e
Simplify map closures to use method reference syntax
Copilot 9bfae6f
Fix scale candidate tables for DominantSharp9, MinorDominantFlat9Flat…
Copilot 89a3096
Expand scale candidate lists with additional high-value options
Copilot ec13da5
Rewrite reason strings for clearer musical context and usage guidance
Copilot 4af6e48
Expand reason strings with richer musical context and usage guidance
Copilot de3739f
Simplify mode/scale grammar to reduce duplication while keeping Rust …
Copilot e83a29b
Add WASM bindings for Mode and Scale types with comprehensive tests
Copilot 8167f56
Add WASM bindings for scale_candidates with 13 comprehensive tests
Copilot 1680991
Remove chord-quality aliases from mode parser (augmentedmajor, half-d…
Copilot b5604c5
Remove chord-quality aliases from grammar (augmented major, half-dimi…
Copilot d6e005a
Fix terminology and theory accuracy in scale candidate reason strings
Copilot 044ba1e
Rename tests and remove redundant comments
Copilot f239f6d
Update kord/src/core/scale_kind.rs
twitchax 00c71c5
Update kord/src/core/scale_kind.rs
twitchax 713d7b0
Update kord/src/core/scale.rs
twitchax 41055e8
Update kord/src/core/mode_kind.rs
twitchax 6e55929
Fix WASM build by replacing dyn_into with unchecked_into
Copilot 7f5f034
Fix WASM tests by adding RefFromJsValue impl for KordScaleCandidate
Copilot 6e7ed84
Fix WASM tests by using unchecked_into correctly for array items
Copilot 114a856
Merge pull request #34 from twitchax/main
twitchax e81eaad
Add type annotations to unchecked_into calls in WASM tests
Copilot 52915c5
Simplify WASM scale_candidates tests to avoid type conversion issues
Copilot 1e76849
Fix diminished scale parsing to allow format without parentheses
Copilot f2d5aeb
Fix diminished scale parsing in Rust parser
Copilot 9d2b023
Refactor code organization: move statics, add ascii_name methods, mov…
Copilot File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use that helper here too.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Using the helper here now. Commit: 5d300ce