Cache on the heap#99
Conversation
|
Hey, why did you make a I thought you were going to add new cache types that weren't going to have const generics anymore |
|
Have you actually read the documentation and/or the code in the list module? |
|
Ah I misread something when I scanned over it. It's indeed Unsure if I like this approach. I'll reflect on it... |
|
My goal was to touch as few things as I can, my change shouldn't be breaking l. |
|
Hey, alright, this is how I would want to see it: The cache traits are pretty simple. I think it's better to duplicate the logic for different types of implementations. For example, the KeyPointerCache could use a hashmap instead of a vec, which would make the cache lookup be So that's what I'd want to see. Separate cache types for heap allocated caches |
This PR makes it so that the user can choose whether to use statically or dynamically allocated cache.
It is useful whenever page count and keys are not known at compile time.
It does that with a
List<T, N>structure, as described in the module.This PR aims to solve issue #94.