Fix/governance wiring gaps#1
Merged
Merged
Conversation
Gap 1 – README.md and run_local.sh: fix stale repo URLs tuned-org-uk/solid-community-rs → Genefold/solid-data-governance-rs doap:homepage in test-subjects.ttl updated to match Gap 2 – server-core/src/middleware.rs: add extract_credentials() Parses Authorization: Bearer <token> and injects Credentials into Axum request extensions so downstream authz layers can read them. Gap 3 – server-core/src/pipeline.rs: wire PermissionReader + Authorizer RequestPipeline::new() now accepts Arc<dyn PermissionReader> and Arc<dyn Authorizer>. build_router() applies authz_middleware which calls permission_reader.read() → authorizer.authorize() before every handler. A PassThroughAuthorizer default is provided so existing tests keep passing. Gap 4 – server-core/src/store.rs: implement ResourceStore on LdpStore Delegates get/put/delete to the existing HashMap so server-core and solid-storage are no longer disconnected. Gap 5 – server-core/src/lib.rs: re-export authz types Gap 6 – integration-tests: add WAC suite Three cases: unprotected GET → 200, protected GET without credentials → 401, WAC-Allow header present on protected resource response. Registered in runner.rs and mod.rs. Legal – .github/CONTRIBUTING.md: volunteer/IP conditions Legal – .github/pull_request_template.md: contributor declaration Legal – LICENSE: already correct, no change
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.