Create B827EBFFFE6AEBC2.json#1774
Open
slefophane wants to merge 2 commits into
Open
Conversation
gonzalocasas
requested changes
Jun 21, 2024
Comment on lines
+175
to
+177
| "server_address": "eu1.cloud.thethings.network", | ||
| "serv_port_up": 1700, | ||
| "serv_port_down": 1700, |
Member
There was a problem hiding this comment.
These fields don't belong at this level of nesting (they belong inside "servers", where you also have them in.
| "serv_port_down": 1700, | ||
| "servers": [ | ||
| { | ||
| "gateway_ID": "B827EBFFFE6AEBC2", |
Member
There was a problem hiding this comment.
This field doesn't not belong here (it belongs outside).
Comment on lines
+186
to
+187
| ] | ||
| "fake_gps": true, |
Member
There was a problem hiding this comment.
There's a missing comma here, please update and validate the json file using any online or offline validator.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.