Add keep_upright to pcb_silkscreen_text#639
Closed
technologyet31-create wants to merge 1 commit into
Closed
Conversation
A renderer can use this to keep reference-designator text readable when a component is rotated (flip any ccw_rotation that would be upside-down, like KiCad's "keep upright"), while text without the flag still honors its raw ccw_rotation. Optional, defaults off — mirrors the existing is_mirrored flag. Co-authored-by: abdalrouf-AAA <236259618+technologyet31-create@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds an optional
keep_upright?: booleantopcb_silkscreen_text(mirrors the existingis_mirroredflag — optional, off by default).It lets a renderer keep reference-designator text readable when a component is rotated (flip any
ccw_rotationthat would render it upside-down, like KiCad's "keep upright"), while text without the flag still honors its rawccw_rotation. This is the property @imrishabh18 asked for in tscircuit/circuit-to-canvas#251 — the renderer will gate its keep-upright behavior on this flag, and@tscircuit/corewill set it on auto-generated refdes.Added to both the zod schema and the interface (
expectTypesMatchkeeps them in sync) plus a small parse test.