Skip to content

http: preserve cookie jar for TLS clients#231

Merged
WineChord merged 1 commit into
trpc-group:mainfrom
Rememorio:http_cookie_jar
Jun 16, 2026
Merged

http: preserve cookie jar for TLS clients#231
WineChord merged 1 commit into
trpc-group:mainfrom
Rememorio:http_cookie_jar

Conversation

@Rememorio

Copy link
Copy Markdown
Collaborator

Summary

  • Preserve the configured http.Client CookieJar when constructing TLS-specific HTTP clients.
  • Add regression coverage for CookieJar handling on TLS requests.

Tests

  • go test ./http -run TestTLSClientInheritsCookieJar -count=1
  • go test ./http -count=1
  • go test ./... -count=1

Close #202

@WineChord WineChord left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@WineChord WineChord merged commit d9ded49 into trpc-group:main Jun 16, 2026
6 checks passed
@github-actions github-actions Bot locked and limited conversation to collaborators Jun 16, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

question: affected/package: http/transport.go中的ClientTransport可否支持自定义stdhttp.Client

2 participants