Make block a visible scope - #177
Conversation
|
Can you update the queries to go with it? (And here, too, |
aa5e3d3 to
71b8d64
Compare
|
The queries should still work unchanged. It is mainly useful for things like I'm currently in the process to rewrite the Helix queries but ran into some performance issues. Not sure if this grammar, the Helix implementation, or too much usage of locals is the issue. |
|
Little bit of column A, little bit of column C. (The use of locals for highlighting is now considered to be a mistake; even upstream is no longer advocating it.) |
Is there an upstream issue/discussion about the topic? I wasn't able to find anything. They are quite nice when they work. I used them for constant and function argument tracking. But there are also issues, especially the queries are getting unwieldy very fast. Combination of low-level grammar and very flexible syntax of Julia. Some sort of hybrid approach with LSP semantic highlighting would probably the best. |
Yes, that's exactly the thinking. (Too bad the LSP situation for Julia has the same problems -- at least the tree-sitter parser does not have to be written in Julia itself...) |
|
@ChrHorn feel free to open this PR at https://github.com/tree-sitter-grammars/tree-sitter-julia |
This should make querying these much easier.
closes #73