fix(node): fix text handling for bytes-like callbacks#465
Merged
ObserverOfTime merged 1 commit intoJul 8, 2026
Merged
Conversation
Member
|
The added test case fails sometimes: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix a segfault in
Node.textwhen the parse source comes from a callback returning a bytes-like object.Related to #435.
What changed
node_get_textto use the normalizedbytearraybuffer when computing length and reading bytes.bytesbytearraymemoryviewWhy
The previous implementation accepted bytes-like callback results, but later treated the original callback return value as if it were always a
bytesobject. That could segfault whenNode.textwas accessed.This change addresses a
node_get_textcrash in the same area discussed in #435.Testing
python -m unittest discover -s tests -v