Fix OptionsFlow crash on HA 2024.x+ (config_entry no longer settable in __init__) - #73
Open
schizek wants to merge 1 commit into
Open
Fix OptionsFlow crash on HA 2024.x+ (config_entry no longer settable in __init__)#73schizek wants to merge 1 commit into
schizek wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
HA 2024.x made
config_entrya read-only property on theOptionsFlowbase class. This integration was still assigning to it in__init__, which caused a crash every time the options dialog was opened:Changes:
config_flow.py: RemovedVictorSmartKillOptionsFlowHandler.__init__and updatedasync_get_options_flowto call the handler with no arguments.async_step_usernow readsself.config_entry.optionsdirectly via the base class property.__init__.py: Changedraise UpdateFailed(exception)toraise UpdateFailed(repr(exception))so error messages in the log are never silently blank when the exception's__str__returns an empty string.Tested on HA 2025.1 with Python 3.14.