[Clang][Modules] Fix -Wunused-variable (#196577)

.ci/compute_projects.py

@@ -40,6 +40,7 @@
 # just invert the dependencies list to give more control over what exactly is
 # tested.
 DEPENDENTS_TO_TEST = {
+    "libc-shared": {"llvm", "clang"},
     "llvm": {
         "bolt",
         "clang",
@@ -80,9 +81,10 @@
 # This mapping describes runtimes that should be tested when the key project is
 # touched.
 DEPENDENT_RUNTIMES_TO_TEST = {
-    "clang": {"compiler-rt"},
+    "clang": {"compiler-rt", "libc"},
     "clang-tools-extra": {"libc"},
     "libc": {"libc"},
+    "libc-shared": {"libcxx", "libcxxabi", "libunwind"},
     "libclc": {"libclc"},
     "compiler-rt": {"compiler-rt"},
     "flang": {"flang-rt"},
@@ -154,8 +156,6 @@
     "flang-rt": "check-flang-rt",
     "libc": "check-libc",
     "libclc": "check-libclc",
-    "lld": "check-lld",
-    "lldb": "check-lldb",
     "mlir": "check-mlir",
     "openmp": "check-openmp",
     "polly": "check-polly",
@@ -185,10 +185,12 @@
     (".github", "workflows", "premerge.yaml"): ".ci",
     ("third-party",): ".ci",
     ("llvm", "utils", "lit"): "lit",
+    ("libc", "shared"): "libc-shared",
+    ("libc", "src", "__support", "math"): "libc-shared",
 }
 
 # Projects that should run tests but cannot be explicitly built.
-SKIP_BUILD_PROJECTS = ["CIR", "lit"]
+SKIP_BUILD_PROJECTS = ["CIR", "lit", "libc-shared"]
 
 # Projects that should not run any tests. These need to be metaprojects.
 SKIP_PROJECTS = ["docs", "gn"]

.ci/compute_projects_test.py

@@ -90,11 +90,12 @@ def test_clang(self):
             "check-clang check-clang-tools check-cross-project check-lldb",
         )
         self.assertEqual(
-            env_variables["runtimes_to_build"], "compiler-rt;libcxx;libcxxabi;libunwind"
+            env_variables["runtimes_to_build"],
+            "compiler-rt;libc;libcxx;libcxxabi;libunwind",
         )
         self.assertEqual(
             env_variables["runtimes_check_targets"],
-            "check-compiler-rt",
+            "check-compiler-rt check-libc",
         )
         self.assertEqual(
             env_variables["runtimes_check_targets_needs_reconfig"],
@@ -167,11 +168,12 @@ def test_cir(self):
             "check-clang check-clang-cir check-clang-tools check-cross-project check-lldb",
         )
         self.assertEqual(
-            env_variables["runtimes_to_build"], "compiler-rt;libcxx;libcxxabi;libunwind"
+            env_variables["runtimes_to_build"],
+            "compiler-rt;libc;libcxx;libcxxabi;libunwind",
         )
         self.assertEqual(
             env_variables["runtimes_check_targets"],
-            "check-compiler-rt",
+            "check-compiler-rt check-libc",
         )
         self.assertEqual(
             env_variables["runtimes_check_targets_needs_reconfig"],
@@ -475,6 +477,23 @@ def test_lldb_windows(self):
         self.assertEqual(env_variables["runtimes_check_targets"], "")
         self.assertEqual(env_variables["runtimes_check_targets_needs_reconfig"], "")
 
+    def test_libc_shared(self):
+        env_variables = compute_projects.get_env_variables(
+            ["libc/shared/math/acos.h"], "Linux"
+        )
+        self.assertEqual(env_variables["projects_to_build"], "clang;lld;llvm")
+        self.assertEqual(
+            env_variables["project_check_targets"], "check-clang check-llvm"
+        )
+        self.assertEqual(
+            env_variables["runtimes_to_build"], "libc;libcxx;libcxxabi;libunwind"
+        )
+        self.assertEqual(
+            env_variables["runtimes_check_targets"],
+            "check-cxx check-cxxabi check-libc check-unwind",
+        )
+        self.assertEqual(env_variables["runtimes_check_targets_needs_reconfig"], "")
+
 
 if __name__ == "__main__":
     unittest.main()

.ci/generate_test_report_lib.py

@@ -212,7 +212,11 @@ def generate_report(
             report.extend(
                 [
                     ":white_check_mark: The build succeeded and no tests ran. "
-                    "This is expected in some build configurations."
+                    "This is not expected and likely means something was "
+                    "configured incorrectly. If you suspect an infrastructure "
+                    "issue, please open an issue at "
+                    "https://github.com/llvm/llvm-project/issues and attach the "
+                    "infrastructure label."
                 ]
             )
         else:

.ci/generate_test_report_lib_test.py

@@ -194,9 +194,9 @@ def test_title_only(self):
             (
                 dedent(
                     """\
-                # Foo
+                    # Foo
 
-                :white_check_mark: The build succeeded and no tests ran. This is expected in some build configurations."""
+                    :white_check_mark: The build succeeded and no tests ran. This is not expected and likely means something was configured incorrectly. If you suspect an infrastructure issue, please open an issue at https://github.com/llvm/llvm-project/issues and attach the infrastructure label."""
                 ),
                 True,
             ),

.ci/metrics/Dockerfile

@@ -1,4 +1,4 @@
-FROM docker.io/python:3.12
+FROM docker.io/python:3.12@sha256:ed942629d18ad03521f9835ff95f3edbfbe99ccd38be6ba64a509ce3c1b149a8
 
 COPY requirements.lock.txt ./
 RUN pip3 install --no-cache-dir -r requirements.lock.txt

.github/CODEOWNERS

@@ -11,6 +11,7 @@
 # See https://llvm.org/docs/DeveloperPolicy.html#maintainers as well as the
 # Maintainers.* files in the the respective subproject directories.
 
+/libc/ @llvm/reviewers-libc
 /libcxx/ @llvm/reviewers-libcxx
 /libcxxabi/ @llvm/reviewers-libcxxabi
 /libunwind/ @llvm/reviewers-libunwind
@@ -79,9 +80,9 @@
 /mlir/lib/Dialect/XeGPU/Transforms @charithaintc @Jianhui-Li
 /mlir/include/mlir/Dialect/XeGPU/TransformOps @charithaintc @Jianhui-Li @tkarna
 /mlir/lib/Dialect/XeGPU/TransformOps @charithaintc @Jianhui-Li @tkarna
-/mlir/include/mlir/Dialect/LLVMIR/XeVM* @silee2
-/mlir/lib/Dialect/LLVMIR/IR/XeVM @silee2
-/mlir/lib/Conversion/*XeVM* @silee2
+/mlir/include/mlir/Dialect/LLVMIR/XeVM* @silee2 @akroviakov
+/mlir/lib/Dialect/LLVMIR/IR/XeVM @silee2 @akroviakov
+/mlir/lib/Conversion/*XeVM* @silee2 @akroviakov
 
 # Bufferization Dialect in MLIR.
 /mlir/include/mlir/Dialect/Bufferization @matthias-springer
@@ -196,12 +197,16 @@
 /clang/bindings/python @DeinAlptraum
 
 # AMDGPU assembler and disassembler
-/llvm-project/llvm/lib/Target/AMDGPU/AsmParser/AMDGPUAsmParser.cpp @jwanggit86 
-/llvm-project/llvm/lib/Target/AMDGPU/Disassembler/AMDGPUDisassembler.cpp @jwanggit86 
- 
+/llvm-project/llvm/lib/Target/AMDGPU/AsmParser/AMDGPUAsmParser.cpp @jwanggit86
+/llvm-project/llvm/lib/Target/AMDGPU/Disassembler/AMDGPUDisassembler.cpp @jwanggit86
+
 # Clang Driver
 /clang/lib/Driver/ToolChains/AMDGPU.cpp @lamb-j
 /clang/lib/Driver/OffloadBundler.cpp @lamb-j @david-salinas
 
 # GlobalIsel
 /llvm/lib/Target/AMDGPU/AMDGPURegBankLegalize* @vangthao95
+
+# AMDGPU Memory Model
+/llvm/lib/Target/AMDGPU/SIMemoryLegalizer* @Pierre-vh @ritter-x2a
+/llvm/lib/Target/AMDGPU/SIInsertWaitcnts* @Pierre-vh @ritter-x2a

.github/workflows/commit-access-greeter.yml

@@ -31,7 +31,6 @@ jobs:
       - name: Add comments to issue
         working-directory: ./llvm/utils/git/
         env:
-          LABEL_NAME: ${{ github.event.label.name }}
           GITHUB_TOKEN: ${{ github.token }}
           ISSUE_NUMBER: ${{ github.event.issue.number }}
         run: |

.github/workflows/containers/github-action-ci-tooling/Dockerfile

@@ -2,7 +2,7 @@ ARG LLVM_VERSION=22.1.0
 # FIXME: Use "${LLVM_VERSION%%.*}" instead of "LLVM_VERSION_MAJOR" once we update runners to Ubuntu-26.04 with Buildah >= 1.37
 ARG LLVM_VERSION_MAJOR=22
 
-FROM docker.io/library/ubuntu:24.04 AS llvm-downloader
+FROM docker.io/library/ubuntu:24.04@sha256:c4a8d5503dfb2a3eb8ab5f807da5bc69a85730fb49b5cfca2330194ebcc41c7b AS llvm-downloader
 ARG LLVM_VERSION
 ARG LLVM_VERSION_MAJOR
 
@@ -20,7 +20,7 @@ RUN apt-get update && \
     rm llvm.tar.xz
 
 
-FROM docker.io/library/ubuntu:24.04 AS base
+FROM docker.io/library/ubuntu:24.04@sha256:c4a8d5503dfb2a3eb8ab5f807da5bc69a85730fb49b5cfca2330194ebcc41c7b AS base
 ENV LLVM_SYSROOT=/opt/llvm
 ENV PATH=${LLVM_SYSROOT}/bin:${PATH}
 
@@ -79,7 +79,7 @@ COPY --from=llvm-downloader /llvm-extract/LLVM-${LLVM_VERSION}-Linux-X64/bin/cla
 
 # Install dependencies for 'pr-code-format.yml' job
 COPY llvm/utils/git/requirements_formatting.txt requirements_formatting.txt
-RUN pip install -r requirements_formatting.txt --break-system-packages && \
+RUN pip install --require-hashes -r requirements_formatting.txt --break-system-packages && \
     rm requirements_formatting.txt
 USER gha
 WORKDIR /home/gha
@@ -95,7 +95,7 @@ COPY clang-tools-extra/clang-tidy/tool/clang-tidy-diff.py ${LLVM_SYSROOT}/bin/cl
 
 # Install dependencies for 'pr-code-lint.yml' job
 COPY llvm/utils/git/requirements_linting.txt requirements_linting.txt
-RUN pip install -r requirements_linting.txt --break-system-packages && \
+RUN pip install --require-hashes -r requirements_linting.txt --break-system-packages && \
     rm requirements_linting.txt
 USER gha
 WORKDIR /home/gha

.github/workflows/containers/github-action-ci-windows/Dockerfile

@@ -45,7 +45,8 @@ RUN regsvr32 /S "C:\BuildTools\DIA SDK\bin\amd64\msdia140.dll" & \
 RUN choco install -y ninja --version 1.13.1 && \
     choco install -y git --version 2.50.1 && \
     choco install -y sccache --version 0.10.0 && \
-    choco install -y python3 --version 3.12.3
+    choco install -y python3 --version 3.12.3 && \
+    choco install -y make --version 4.4.1
 
 # Testing requires psutil
 RUN pip install psutil

.github/workflows/containers/libc/Dockerfile

@@ -8,13 +8,32 @@ RUN apt-get update && \
     libgmp-dev \
     libmpc-dev \
     ninja-build \
+    build-essential \
+    gcc-9 \
+    g++-9 \
+    gcc-11 \
+    g++-11 \
+    qemu-user-static \
+    libc6-dev-arm64-cross \
+    libstdc++6-arm64-cross \
+    gcc-aarch64-linux-gnu \
+    g++-aarch64-linux-gnu \
+    libc6-dev-riscv64-cross \
+    libstdc++6-riscv64-cross \
+    gcc-riscv64-linux-gnu \
+    g++-riscv64-linux-gnu \
+    libc6-dev-ppc64el-cross \
+    libstdc++6-ppc64el-cross \
+    gcc-powerpc64le-linux-gnu \
+    g++-powerpc64le-linux-gnu \
     sudo \
     sccache \
     wget \
     lsb-release \
     software-properties-common \
     gnupg \
     cmake \
+    m4 \
     linux-libc-dev && \
     apt-get clean && \
     rm -rf /var/lib/apt/lists/*
@@ -23,6 +42,75 @@ RUN wget https://apt.llvm.org/llvm.sh && \
     chmod +x llvm.sh && \
     sudo ./llvm.sh 23 && \
     rm llvm.sh
+
+# Install gmp and mpfr for cross compilation
+RUN wget https://ftp.gnu.org/gnu/gmp/gmp-6.3.0.tar.xz && \
+    tar -xf gmp-6.3.0.tar.xz && \
+    cd gmp-6.3.0 && \
+    ./configure --host=riscv64-linux-gnu --prefix=/usr/riscv64-linux-gnu && \
+    make -j8 && \
+    sudo make install && \
+    cd .. && \
+    rm -rf gmp-6.3.0 && \
+    rm gmp-6.3.0.tar.xz
+
+RUN wget https://ftp.gnu.org/gnu/mpfr/mpfr-4.2.2.tar.xz && \
+    tar -xf mpfr-4.2.2.tar.xz && \
+    cd mpfr-4.2.2 && \
+    ./configure --host=riscv64-linux-gnu --prefix=/usr/riscv64-linux-gnu \
+    --with-gmp=/usr/riscv64-linux-gnu && \
+    make -j8 && \
+    sudo make install && \
+    cd .. && \
+    rm -rf mpfr-4.2.2 && \
+    rm mpfr-4.2.2.tar.xz
+
+RUN wget https://ftp.gnu.org/gnu/mpc/mpc-1.4.1.tar.xz && \
+    tar -xf mpc-1.4.1.tar.xz && \
+    cd mpc-1.4.1 && \
+    ./configure --host=riscv64-linux-gnu --prefix=/usr/riscv64-linux-gnu \
+    --with-gmp=/usr/riscv64-linux-gnu \
+    --with-mpfr=/usr/riscv64-linux-gnu && \
+    make -j8 && \
+    sudo make install && \
+    cd .. && \
+    rm -rf mpc-1.4.1 && \
+    rm mpc-1.4.1.tar.xz
+
+# Install gcc-7 and g++-7.
+RUN wget https://ftp.gnu.org/gnu/gcc/gcc-7.5.0/gcc-7.5.0.tar.xz && \
+    tar -xf gcc-7.5.0.tar.xz && \
+    cd gcc-7.5.0 && \
+    ./contrib/download_prerequisites && \
+    cd .. && \
+    mkdir gcc-7 && \
+    cd gcc-7 && \
+    ../gcc-7.5.0/configure --prefix=/usr/local/gcc7 --enable-languages=c,c++ \
+    --disable-multilib --disable-libsanitizer && \
+    make -j8 && \
+    sudo make install && \
+    cd .. && \
+    rm -rf gcc-7 && \
+    rm -rf gcc-7.5.0 && \
+    rm gcc-7.5.0.tar.xz
+
+# Install gcc-8 and g++-8.
+RUN wget https://ftp.gnu.org/gnu/gcc/gcc-8.5.0/gcc-8.5.0.tar.xz && \
+    tar -xf gcc-8.5.0.tar.xz && \
+    cd gcc-8.5.0 && \
+    ./contrib/download_prerequisites && \
+    cd .. && \
+    mkdir gcc-8 && \
+    cd gcc-8 && \
+    ../gcc-8.5.0/configure --prefix=/usr/local/gcc8 --enable-languages=c,c++ \
+    --disable-multilib --disable-libsanitizer && \
+    make -j8 && \
+    sudo make install && \
+    cd .. && \
+    rm -rf gcc-8 && \
+    rm -rf gcc-8.5.0 && \
+    rm gcc-8.5.0.tar.xz
+
 
 # Debian has a multilib setup, so we need to symlink the asm directory.
 # For more information, see https://wiki.debian.org/Multiarch/LibraryPathOverview