feat: Detect outdated CLI versions and auto-prompt/suggest upgrade path to users. by blainekasten · Pull Request #456 · togethercomputer/together-py

blainekasten · 2026-07-20T15:32:39Z

Summary

start the cached PyPI version lookup immediately before command execution so setup failures cannot leak background-task errors
call VersionCheck.inform() after command completion and resource cleanup, with a bounded wait for version resolution
prompt only when stdin, stdout, and stderr are TTYs; keep redirected and JSON output clean
suppress prompts after failed/interrupted commands while still printing upgrade guidance
preserve command exit status when the user interrupts the upgrade prompt
cache successful checks for 24 hours and fail open on network/cache errors
compare Together's major.minor.patch releases without adding a runtime dependency
detect uv-tool and pipx installs when selecting the upgrade command
preserve the latest light/dark CLI theme behavior while routing update notices to stderr

Testing

34 passed across version-check, launcher, and console-theme tests
full Ruff and formatting checks pass
targeted Pyright and mypy pass
uv build succeeds

Linear: DX-774

Linear Issue: DX-774

Co-authored-by: Blaine Kasten <blainekasten@gmail.com>

broly-code-security-scanner · 2026-07-20T15:32:54Z

Broly Security Scan

Note

✅ Clean scan
No vulnerabilities detected in this PR.

Note

Re-scan this PR anytime with /broly scan — useful after /broly undismiss, or to refresh findings without a new push.

Broly — SAST (zai-org/GLM-5.2) · Secrets · SCA · GH Actions (zizmor) · Containers · SBOM · Powered by Together AI

Co-authored-by: Blaine Kasten <blainekasten@gmail.com>

… into cursor/cli-version-upgrade-00e1 # Conflicts: # src/together/lib/cli/__init__.py # src/together/lib/cli/utils/_version_check.py # tests/cli/test_main.py # tests/cli/test_version_check.py Co-authored-by: Blaine Kasten <blainekasten@gmail.com>

blainekasten · 2026-07-21T21:07:19Z

@cursoragent resolve conflicts

cursor · 2026-07-21T21:07:24Z

Conflicts resolved and pushed. PR is now mergeable.

Preserved the new light/dark console architecture plus stderr update notices. 30 tests, lint, type checks, and build pass.

…grade-00e1 # Conflicts: # src/together/lib/cli/utils/_console.py Co-authored-by: Blaine Kasten <blainekasten@gmail.com>

zainhas · 2026-07-22T00:55:50Z

        Parameter(name="json", group=global_options, negative=(), help="Output the response in JSON format"),
    ] = False,
 ) -> None:
+    version_check = VersionCheck()


if anything fails between here and the try at L346 ie. missing API key, project resolve we'll get noise on stderr.

lets move this right before the try?

zainhas · 2026-07-22T00:57:13Z

+            return
+
+        try:
+            latest_version = await self._latest_version


theres no timeout on this await, should we wrap this in a asyncio.wait_for

zainhas · 2026-07-22T00:59:00Z

    if not no_auth_command and client.project_id is None:
        client.project_id = await _resolve_project_id(client)

+    is_interactive = sys.stdin.isatty() and sys.stderr.isatty() and not _is_agent_or_ci()


stdout isn't checked here, but the prompt writes to stdout - so together models list | grep foo gets escape codes in the pipe. add sys.stdout.isatty()?

zainhas · 2026-07-22T01:00:47Z

-        flush_pending_events()
-        await client.close()
+        try:
+            flush_pending_events()


this runs even when the command failed, so users get an upgrade prompt right after an error. and ctrl-C at the prompt clobbers the exit code. maybe just print the notice, no prompt, on failure?

blainekasten · 2026-07-22T17:49:37Z

@cursoragent address all the feedback from Zain. Either respond on the comments if you disagree, or push changes addressing his concerns.

cursor · 2026-07-22T17:49:43Z

Addressed all Zain feedback and pushed:

Delayed checker creation until command execution.
Added bounded resolution timeout.
Added stdout TTY detection.
Disabled prompts after failures/interruption.
Preserved exit status on prompt Ctrl-C.

34 tests pass; lint, types, and build pass.

Co-authored-by: Blaine Kasten <blainekasten@gmail.com>

cursor

Docs update opened: https://github.com/togethercomputer/mintlify-docs/pull/1303

View PR

_{Sent by Cursor Automation: Update mintlify-docs from code changes}

feat(cli): prompt when a newer version is available

9893721

Co-authored-by: Blaine Kasten <blainekasten@gmail.com>

test(cli): verify update notices preserve JSON output

5f765d6

Co-authored-by: Blaine Kasten <blainekasten@gmail.com>

blainekasten commented Jul 20, 2026

View reviewed changes

Comment thread pyproject.toml Outdated

blainekasten commented Jul 20, 2026

View reviewed changes

Comment thread src/together/lib/cli/__init__.py Outdated

cursoragent and others added 3 commits July 20, 2026 18:06

refactor(cli): compare release versions without dependency

b6dc78d

Co-authored-by: Blaine Kasten <blainekasten@gmail.com>

fix(cli): check for updates after command completion

ef2f0a7

Co-authored-by: Blaine Kasten <blainekasten@gmail.com>

simplify logic

0538934

blainekasten commented Jul 21, 2026

View reviewed changes

Comment thread src/together/lib/cli/utils/_version_check.py Outdated

cursoragent and others added 2 commits July 21, 2026 20:36

refactor(cli): resolve version checks concurrently

a6f08ac

Co-authored-by: Blaine Kasten <blainekasten@gmail.com>

blainekasten changed the title ~~Detect outdated CLI versions and offer upgrades~~ feat: Detect outdated CLI versions and auto-prompt/suggest upgrade path to users. Jul 21, 2026

blainekasten marked this pull request as ready for review July 21, 2026 21:07

Merge remote-tracking branch 'origin/main' into cursor/cli-version-up…

363d2e2

…grade-00e1 # Conflicts: # src/together/lib/cli/utils/_console.py Co-authored-by: Blaine Kasten <blainekasten@gmail.com>

zainhas requested changes Jul 22, 2026

View reviewed changes

fix(cli): make update notifications failure-safe

d7fba7a

Co-authored-by: Blaine Kasten <blainekasten@gmail.com>

zainhas approved these changes Jul 22, 2026

View reviewed changes

blainekasten merged commit e870160 into main Jul 22, 2026
11 of 12 checks passed

github-actions Bot mentioned this pull request Jul 22, 2026

release: 2.26.0 #464

Merged

cursor Bot reviewed Jul 22, 2026

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

feat: Detect outdated CLI versions and auto-prompt/suggest upgrade path to users.#456

feat: Detect outdated CLI versions and auto-prompt/suggest upgrade path to users.#456
blainekasten merged 9 commits into
mainfrom
cursor/cli-version-upgrade-00e1

blainekasten commented Jul 20, 2026 •

edited by cursor Bot

Loading

Uh oh!

broly-code-security-scanner Bot commented Jul 20, 2026 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

Uh oh!

blainekasten commented Jul 21, 2026

Uh oh!

cursor Bot commented Jul 21, 2026 •

edited

Loading

Uh oh!

zainhas Jul 22, 2026

Uh oh!

zainhas Jul 22, 2026

Uh oh!

zainhas Jul 22, 2026

Uh oh!

zainhas Jul 22, 2026

Uh oh!

blainekasten commented Jul 22, 2026

Uh oh!

cursor Bot commented Jul 22, 2026 •

edited

Loading

Uh oh!

Uh oh!

cursor Bot left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

blainekasten commented Jul 20, 2026 • edited by cursor Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Testing

Uh oh!

broly-code-security-scanner Bot commented Jul 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Broly Security Scan

Uh oh!

Uh oh!

Uh oh!

Uh oh!

blainekasten commented Jul 21, 2026

Uh oh!

cursor Bot commented Jul 21, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

zainhas Jul 22, 2026

Choose a reason for hiding this comment

Uh oh!

zainhas Jul 22, 2026

Choose a reason for hiding this comment

Uh oh!

zainhas Jul 22, 2026

Choose a reason for hiding this comment

Uh oh!

zainhas Jul 22, 2026

Choose a reason for hiding this comment

Uh oh!

blainekasten commented Jul 22, 2026

Uh oh!

cursor Bot commented Jul 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

cursor Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

blainekasten commented Jul 20, 2026 •

edited by cursor Bot

Loading

broly-code-security-scanner Bot commented Jul 20, 2026 •

edited

Loading

cursor Bot commented Jul 21, 2026 •

edited

Loading

cursor Bot commented Jul 22, 2026 •

edited

Loading