tests: add edge-case tests for uncount()#1643
Closed
LeonidasZhak wants to merge 1 commit into
Closed
Conversation
Add 7 test blocks covering: - Factor column preservation - Date column preservation - POSIXct column preservation - .id counter resetting per group - All zero weights producing empty data frame - NA weights producing informative error - List column preservation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| }) | ||
|
|
||
| test_that("preserves POSIXct columns", { | ||
| times <- as.POSIXct(c("2024-01-01 10:00:00", "2024-06-15 14:30:00"), tz = "UTC") |
Contributor
There was a problem hiding this comment.
[air] reported by reviewdog 🐶
Suggested change
| times <- as.POSIXct(c("2024-01-01 10:00:00", "2024-06-15 14:30:00"), tz = "UTC") | |
| times <- as.POSIXct( | |
| c("2024-01-01 10:00:00", "2024-06-15 14:30:00"), | |
| tz = "UTC" | |
| ) |
Author
|
Withdrawing this small automated PR while I consolidate an oversized batch of contributions and reduce maintainer review burden. Sorry for the noise, and thank you for maintaining the project. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds 7 edge-case test blocks for
uncount()covering:.idcounter resetting per groupAll 24 tests pass (10 existing + 14 new). No regressions introduced.
Note: PR #1619 addresses the
.datapronoun bug inuncount()— this PR focuses purely on test coverage for data cleaning edge cases.