tests: add factor edge-case tests for unite() and separate()#1639
Closed
LeonidasZhak wants to merge 5 commits into
Closed
tests: add factor edge-case tests for unite() and separate()#1639LeonidasZhak wants to merge 5 commits into
LeonidasZhak wants to merge 5 commits into
Conversation
Filter out infinite values before computing range in full_seq.numeric(). This prevents the cryptic 'missing value where TRUE/FALSE needed' error when input contains Inf or -Inf values. Fixes tidyverse#1496
…idyverse#1509) - Add clear error message when trying to expand or complete on a grouping column - Error now says 'Can't expand/complete on a grouping column' instead of cryptic 'object not found' - Suggests using ungroup() or working with non-grouping columns - Updated tests to use snapshot testing for error messages
…ep and cols_remove = FALSE (tidyverse#1499, tidyverse#1588) When using names_sep with cols_remove = FALSE, the original column was being renamed by unpack() (e.g., x -> x_x). This fix detects when the original column is present in the packed data and restores it after unpacking. Fixes tidyverse#1499 Fixes tidyverse#1588
- unite(): factor→character conversion, unused levels, na.rm with factors - separate(): factor→character conversion, NA preservation, convert = TRUE with factors These functions are commonly used in data cleaning workflows with factor columns but lacked explicit test coverage for factor input behavior.
Author
|
Withdrawing this small automated PR while I consolidate an oversized batch of contributions and reduce maintainer review burden. Sorry for the noise, and thank you for maintaining the project. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds edge-case tests for
unite()andseparate()with factor column input. Both functions convert factor input to character output, but this behavior had zero test coverage.Changes
na.rmwith factors, unused factor levelsconvert = TRUEwith factorsWhy
Factor columns are ubiquitous in data cleaning workflows.
unite()andseparate()are commonly used with categorical variables. These tests document the expected factor-handling behavior.Tests run