Clarify crossing factor level behavior#1632
Closed
LeonidasZhak wants to merge 1 commit into
Closed
Conversation
Member
|
Assuming this is the same as tidymodels/broom#1281 (comment) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1526.
This clarifies that
crossing()uses the full set of levels for factor inputs, not just the values present in the data. I kept the change scoped tocrossing()becausenesting()andexpand_grid()do not independently expand factor levels in the same way.Checks:
crossing()expands the missing factor level in the issue reprexRscript -e 'tools::checkRd("man/expand.Rd")'\n-git diff --check\n-R CMD build --no-build-vignettes .\n-R_LIBS_USER=/tmp/tune-r-lib _R_CHECK_FORCE_SUGGESTS_=false R CMD check --no-manual --ignore-vignettes --no-build-vignettes --no-tests tidyr_1.3.2.9000.tar.gz