Skip to content

Fix #1583: Support .data pronoun in uncount() #1629

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mrv0for0vandeta wants to merge 1 commit into from
Closed

Fix #1583: Support .data pronoun in uncount() #1629

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 15 additions & 2 deletions R/uncount.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,8 +44,21 @@ uncount.data.frame <- function(data, weights, ..., .remove = TRUE, .id = NULL) {

# NOTE it was decided to also remove grouping variables as there is no clear
# best answer. See https://github.com/tidyverse/tidyr/pull/1070
if (.remove && quo_is_symbol(weights_quo)) {
out[[as_string(get_expr(weights_quo))]] <- NULL

@github-actions github-actions Bot May 13, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[air] reported by reviewdog 🐶

Suggested change

# Handle removal of weight column for both direct symbols and .data pronoun
# Fixes #1583 - support for .data$column syntax
if (.remove) {
weights_expr <- get_expr(weights_quo)

@github-actions github-actions Bot May 13, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[air] reported by reviewdog 🐶

Suggested change

if (quo_is_symbol(weights_quo)) {
# Simple case: uncount(df, w)
out[[as_string(weights_expr)]] <- NULL
} else if (is_call(weights_expr, "$", n = 2) &&
identical(weights_expr[[2]], sym(".data"))) {
Comment on lines +56 to +57

@github-actions github-actions Bot May 13, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[air] reported by reviewdog 🐶

Suggested change
} else if (is_call(weights_expr, "$", n = 2) &&
identical(weights_expr[[2]], sym(".data"))) {
} else if (
is_call(weights_expr, "$", n = 2) &&
identical(weights_expr[[2]], sym(".data"))
) {

# .data pronoun case: uncount(df, .data$w)
col_name <- as_string(weights_expr[[3]])
out[[col_name]] <- NULL
}
}

if (!is.null(.id)) {
Expand Down
Loading