fix(northernlights): adapt to NOAA JSON API changes - #3211
Open
objectivelabs wants to merge 1 commit into
Open
Conversation
NOAA SWPC products now return object-shaped JSON (Kp, proton_speed, bz_gsm) instead of legacy table/dict shapes; parsing caused a runtime error and blank previews. Use explicit User-Agent, http TTL cache, resilient parsers with legacy fallbacks, optional marquee only for active ALERT/WARNING/WATCH, and clarify manifest description copy. Co-authored-by: Cursor <cursoragent@cursor.com>
objectivelabs
requested review from
danielsitnik,
drudge and
matslina
as code owners
May 14, 2026 13:23
Next StepsHello! Thank you so much for your change 🤜 🤛 . There are a few things you need to do:
Manual Review RequiredHang tight! A Tidbyt engineer will be by shortly to review your change. Here is what they will be looking for:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NOAA SWPC products now return object-shaped JSON (Kp, proton_speed, bz_gsm) instead of legacy table/dict shapes; parsing caused a runtime error and blank previews. Use explicit User-Agent, http TTL cache, resilient parsers with legacy fallbacks, optional marquee only for active ALERT/WARNING/WATCH, and clarify manifest description copy.