Consider missing DKIM DNS records an error (#942)#947
Merged
Conversation
davinotdavid
approved these changes
Jun 13, 2026
davinotdavid
left a comment
davinotdavid
left a comment
Contributor
There was a problem hiding this comment.
QA Log
- Checked diff
- Ran tests
- Can verify that it now shows dkim records as critical:
--
Note (to self?): this UI will change very soon #955 (comment)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed?
Missing DKIM DNS records are now considered an error.
Why?
If they don't set it up deliverability will suffer, which isn't good for the user and will also likely result in higher support volumes. As long as they are updating their DNS records, there's no good reason to not add the DKIM records while they are at it.
Applicable Issues
Closes #942
QA Log
Screenshots