Refactor notice-bar positioning in Keycloak Vue app#1057
Open
davinotdavid wants to merge 6 commits into
Open
Conversation
Contributor
Author
|
Failed tests are unrelated btw! |
Contributor
FYI Earlier I filed #1058 for that, contact tests failing when run on PRs/local stack. |
7c82f0e to
e59ab24
Compare
MelissaAutumn
requested changes
Jul 4, 2026
MelissaAutumn
left a comment
Member
There was a problem hiding this comment.
I'm not at my work laptop atm, but here's an initial review.
d6bd0e5 to
eb55788
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed?
message-barcomponent to theBaseTemplateand removed all the duplicated message-bars from all the views in the Keycloak vue apppanel-contentssection to be horizontally even (6rem). Approved by the design team!.notice-barand.logo-linkmax-heightin the panel so that it can grow according to its content instead of overflowing. This is perhaps a bit controversial as the left side orb graphic grows a bit when a layout shift happens (I know @MelissaAutumn changed this purposely before). IMHO it is less jarring to have it grow rather than overflowing but can put it back if there's a counter argument for it.Note
Since this updates all the Keycloak app notices, please peruse the app to help test. I did trigger some of them and they look fine for me though!
Why?
Limitations and Notes
Applicable Issues
Fixes #1036
Fixes #1021
Screenshots