fix(send): tidy up the Encrypted Files page layout - #1063
Open
aaspinwall wants to merge 1 commit into
Open
Conversation
Re-applies the layout polish from the abandoned PR #904: - FolderNavigation: make upload section flex-1 and enlarge drop zone (min-h-[24rem]) - FolderView: neutral gray empty-state border; drop unused .wrapper class/style - HomeView: smaller muted email header; only show aside when a file/folder is selected; constrain page-wrapper to full width within max-width 1200px Also adds before/after screenshots. Validated: typecheck, eslint, and frontend build all pass. Frontend unit-test failures are pre-existing on main (identical 44 failures with or without this change; unrelated jsdom/localStorage env issues).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed?
Tidied up the Encrypted Files page so it looks more finished and uses the space better. The file list now stretches across the full width, the empty "No files" message looks intentional instead of having an odd blue outline, the "Drop files here" upload area is larger, the account email at the top is calmer, and the page no longer gets cut off on smaller windows.
Concretely, this touches 3 Vue components:
FolderNavigation.vue— upload section is nowflex-1and the drop zone is enlarged (min-h-[24rem]).FolderView.vue— empty-state box uses a neutral gray border instead of blue; the now-unused.wrapperclass and itsmin-widthstyle are removed.HomeView.vue— smaller, muted account-email header; the right-hand detailasideis shown only when a file or folder is selected;page-wrapperis set towidth: 100%so it fills up to itsmax-width: 1200px.AI disclosure: I am an AI bot. This PR is agent-written end to end (branch, code, validation, and this description). It recreates the previously-abandoned PR #904 on a fresh branch off
mainand re-verifies it. A human directed the task and reviews the result and the before/after screenshots.Why?
The page felt unfinished: a large empty panel sat on the right and squeezed the file list into the middle, leaving wasted space on both sides; the empty-state box had a bright blue outline that looked accidental; the upload area was small with a big gap beneath it; and on narrower windows the page spilled past the edge of the screen so you had to scroll sideways.
Limitations and Notes
pnpm typecheck(tsc --noEmit),eslint, and the frontendbuildall pass on this branch. The frontend unit-test suite has 44 pre-existing failures (jsdom/localStorageenvironment issues) that are present onmainunchanged — this PR introduces no new test failures and touches no code those tests cover.Applicable Issues
Closes #903
Screenshots
Before
After
Narrower window (no more sideways scrolling)