fill(tb-dev,tb-prod): real RDS security group + private subnet IDs#1
Merged
Conversation
From the applied mzla-tb-dev stack (platform-infrastructure#530): - vpcSecurityGroupIDs -> sg-0550595389f41cfca (rds_sg_keycloak_id) - subnetIDs -> subnet-044e18f3022fb9ee1 (1a), subnet-01084662e5e16dce9 (1b) Image newName/newTag still placeholders pending the mirror (platform-infrastructure#531). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
From the applied mzla-tb-prod stack (platform-infrastructure #552/#553): - vpcSecurityGroupIDs -> sg-026550adef0d02cdb (rds_sg_keycloak_id) - subnetIDs -> subnet-085a71891b27bd24c (1a), subnet-0b863a1876ec121cb (1b) Both overlays now build with real AWS values; image newName/newTag remain pending the source-image decision (platform-infrastructure#531). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
aatchison
changed the title
From a 5-lens local review: - pin kubernetes.io/arch=arm64 on the StatefulSet nodeSelector (image is arm64; guards against a future mixed-arch pool) and add a pod-level securityContext (runAsNonRoot + seccompProfile RuntimeDefault). - bound the keycloak-data emptyDir (sizeLimit 1Gi). - tb-prod: autoMinorVersionUpgrade=false to avoid engine bumps during the #142 migration window. - .gitignore: add IDE/OS entries; validate.yaml: note why no OIDC is needed. Deliberately NOT changed: real SG/subnet/CF-account values stay committed (GitOps needs them; matches thundermail-deploy precedent); default ispn cache + CrashLoop- until-ConfigMap behavior kept for parity with Staff SSO. DR backup CronJob, public /admin Cloudflare Access deny, and alert VMRules remain tracked follow-ups for #142. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Mirrored thunderbird/accounts:keycloak-e7ef91efd43f... (multi-arch amd64+arm64, from accounts PR #974) into the per-account keycloak-customer ECR repos and pointed each overlay's images: transform at it: - tb-dev: 718959508124.dkr.ecr.eu-central-1.amazonaws.com/keycloak-customer - tb-prod: 689951664252.dkr.ecr.eu-central-1.amazonaws.com/keycloak-customer tag keycloak-e7ef91efd43f7619e7fc522fb64737b56efb9ffc (OCI image index). Both overlays build clean. Resolves the last #531 placeholder; #540 can go ready for tb-dev. tb-prod tag re-aligns to the accounts-prod release at cutover (#142). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fills the
overlays/{tb-dev,tb-prod}AWS placeholders with the real values from the applied Pulumi stacks (platform-infrastructure#530 for tb-dev; #552/#553 for tb-prod).vpcSecurityGroupIDssubnetIDs(1a / 1b)sg-0550595389f41cfcasubnet-044e18f3022fb9ee1/subnet-01084662e5e16dce9sg-026550adef0d02cdbsubnet-085a71891b27bd24c/subnet-0b863a1876ec121cbkubectl kustomizebuilds clean for both overlays.Still placeholder (tracked)
newName/newTag— pending the source-image decision (platform-infrastructure#531). Source images confirmed in mzla-legacy ECRthunderbird/accounts: stagekeycloak-3be363d…, prodkeycloak-ebbd889….🤖 Generated with Claude Code