Skip to content

Nil-pointer panic: mapping can reference repos not in Repositories #743

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
udf2457 wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Nil-pointer panic: mapping can reference repos not in Repositories #743

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5a3f2a2
Nil-pointer panic: mapping can reference repos not in Repositories
udf2457 Jun 19, 2026
6fe96af
Validate non-null mappings in mapFile
udf2457 Jun 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions metadata/multirepo/multirepo.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,6 +102,15 @@ func NewConfig(repoMap []byte, roots map[string][]byte) (*MultiRepoConfig, error
}
}

// validation pass against malformed or adversarially crafted map
for _, m := range mapFile.Mapping {
for _, repo := range m.Repositories {
if _, ok := mapFile.Repositories[repo]; !ok {
return nil, fmt.Errorf("mapping references unknown repository %q", repo)
}
}
}
Comment on lines +105 to +115
Comment on lines +105 to +115

return &MultiRepoConfig{
RepoMap: mapFile,
TrustedRoots: roots,
Expand Down