Idiomatic Go modernization#741
Open
udf2457 wants to merge 4 commits into
Open
Conversation
Signed-off-by: udf2457 <udf2457@users.noreply.github.com>
Signed-off-by: udf2457 <udf2457@users.noreply.github.com>
Signed-off-by: udf2457 <udf2457@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Modernizes small portions of the Go codebase by adopting newer Go idioms (any, range) without changing behavior.
Changes:
- Replaced an index-based loop with a
rangeloop in path pattern matching logic. - Switched
interface{}toanyin JSON unmarshalling and test utilities.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| metadata/metadata.go | Uses for i := range ... for clearer iteration over path parts. |
| metadata/marshal.go | Replaces interface{} with any in UnmarshalJSON assignments. |
| internal/testutils/simulator/repository_simulator.go | Replaces map[string]interface{} with map[string]any in delegation metadata. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
rdimitrov
approved these changes
Jun 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.