Support serviceAccountName configuration overwrite#2
Conversation
sergicastro
left a comment
sergicastro
left a comment
There was a problem hiding this comment.
Overall looks good to me. But before merging this we should consider how we're managing the project.
I would keep main branch mirrored from the upstream project, because we don't plan to release major versions.
Then:
- we have
release-v1.16.xwith our own fixes (like CVEs). - we can do the same with version v1.17.x (the last one released by upstream).
TSB is currently using v1.16.x, so I would open this PR to release-v1.16.x and we can quickly tag a new patch version for TSB 1.9.
Later, we can port it to release-v1.17.x and update the dependency for TSB 1.10, giving us more time to play with this new version.
| #CREATE USER $customUserName WITH PASSWORD '$POSTGRES_MYAPP_PASSWORD'; | ||
| #CREATE DATABASE $customDatabaseName; | ||
| #\connect $customDatabaseName; | ||
| #GRANT ALL ON SCHEMA public TO $customUserName; |
There was a problem hiding this comment.
what this change is intended for?
There was a problem hiding this comment.
Oh yes, this is autogenerated, I run a make all, which does a make generate and this showed up.
I think last time it was changed:
6f4f3c0#diff-90e4e58ab89abdeab871e3d899e938c306f9ac97bc12da9fa9883169649ababaR88
, but then forgot to run make generate or add the changes.
Also this is a comment in the config file.
|
Regarding how to manage the project. |
|
@sergicastro this PR #3 is for |
|
I've put that PR in draft, let's see if the upstream issue gets merged first. |
2 participants
No description provided.