fix(x11/opensubdiv): correct absolute paths in provided CMake files#24964
Merged
Conversation
- Context: similar to termux#24956. This might be helpful for a future nested dependency of Blender. - Fixes this error when some projects import `opensubdiv` through CMake, by preventing the generation of a malformed path `/data/data/com.termux/files/usr//data/data/com.termux/files/usr/lib` in `OpenSubdivConfig.cmake`: ``` CMake Error at /data/data/com.termux/files/usr/lib/cmake/OpenSubdiv/OpenSubdivConfig.cmake:11 (message): File or directory /data/data/com.termux/files/usr//data/data/com.termux/files/usr/lib referenced by variable OpenSubdiv_LIB_DIR does not exist ! Call Stack (most recent call first): /data/data/com.termux/files/usr/lib/cmake/OpenSubdiv/OpenSubdivConfig.cmake:28 (set_and_check) cmake/defaults/Packages.cmake:225 (find_package) CMakeLists.txt:23 (include) -- Configuring incomplete, errors occurred! ``` - Copied and pasted from PixarAnimationStudios/OpenSubdiv#1315
Member
Author
|
I will merge it 24 hours from now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context: similar to bump(main/oidn): 2.3.3 #24956. This might be helpful for a future nested dependency of Blender.
Fixes this error when some projects import
opensubdivthrough CMake, by preventing the generation of a malformed path/data/data/com.termux/files/usr//data/data/com.termux/files/usr/libinOpenSubdivConfig.cmake: