Skip to content

FIX: update git hook and fix CI#70

Merged
madcampos merged 4 commits into
mainfrom
chore/fix-git-and-ci
Sep 18, 2025
Merged

FIX: update git hook and fix CI#70
madcampos merged 4 commits into
mainfrom
chore/fix-git-and-ci

Conversation

@madcampos

@madcampos madcampos commented Sep 16, 2025

Copy link
Copy Markdown

Summary

  • Re-enable the git hook for building the project pre-push.
  • Update nightly CI run to disable the CRON job.

Details

Re-enabling the git hook

From a comment below:

TL;DR: It makes sure the UI gets built every time we do a git push.

The longer explanation:

The prepare script runs every time someone install packages through npm (i.e. run npm install).

This command (npm install) is what gets all of the dependencies for running a local dev server for the UI. Without doing that the dependencies will not exist on disk and the dev server will not run.

The prepare script will then configure git to run the hooks on the .githooks directory. We only have the pre-push hook configured.

The pre-push hook will then run the command to build the UI and update the server directory with the built version of the project.

If the build is different then what will be pushed, a new commit will be created and the push will fail.

So from the developer perspective, in the best case where everything is up to date your push will just work. And on the worst case you have to run git push twice.

This is configured on push instead of commit so the build doesn't slow down development as it takes a little bit for the build to run.

It makes more sense to run the build only once when all the changes are bundled rather than once per change.

Disabling the CRON job on CI

From a comment below:

The nightly build is failing for a while now. The thought process is that it doesn't make sense to waste resources in something that is failing a lot. It also generates a wheel of only model-explorer with it's builtin adapters.

So, maybe it is better to have the CI process for generating a wheel run from the tt-mlir repo along with our adapter for model-explorer.

@madcampos madcampos self-assigned this Sep 16, 2025
@madcampos madcampos marked this pull request as ready for review September 17, 2025 19:01
Comment thread .github/workflows/nightly-release.yml Outdated
Comment thread src/ui/package.json
@madcampos madcampos merged commit 550f98b into main Sep 18, 2025
2 checks passed
@madcampos madcampos deleted the chore/fix-git-and-ci branch October 3, 2025 15:47
@madcampos madcampos restored the chore/fix-git-and-ci branch October 3, 2025 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants