Skip replication updates for deleted-workflow orphan runs#10673
Draft
jiechenz wants to merge 1 commit into
Draft
Skip replication updates for deleted-workflow orphan runs#10673jiechenz wants to merge 1 commit into
jiechenz wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed?
On the passive replication-apply path,
dispatchForExistingWorkflownow treats a closed target run with no current execution record (currentRunID == "") as a deleted-workflow no-op.Why?
A reset/continue-as-new + delete the current run can leave the old closed run as orphan, this is true on passive side as workflow deletion will replicate to passive as well.
Then a force-replication
SyncWorkflowStatetask on that orphan will hitcurrentRunId == ""and results in "unable to locate current workflow during update" error.This fix skip the
SyncWorkflowStatewhen orphan is in post-deletion state.How did you test it?
Potential risks