Fix TaskAddHook version value#10670
Open
ShahabT wants to merge 1 commit into
Open
Conversation
5 tasks
rkannan82
approved these changes
Jun 12, 2026
02strich
approved these changes
Jun 12, 2026
02strich
left a comment
02strich
left a comment
Contributor
There was a problem hiding this comment.
Looks fine for wci but wondering whether the other used of targetVersion don't have the same issue and shouldn't use it?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed?
Pass
syncMatchQueue's version to TaskAddHooks instead oftargetVersion.Why?
TargetVersion is always routing-config-deriven. For pinned workflows, targetVersion is not necessarily the same as the pinned version.
TaskAddHooks need the version that would be able to process the task, so in the case that pinned version is different from target version, we should use pinned version.
How did you test it?
Potential risks
none