Use Await in task queue stats tests#10660
Open
stephanos wants to merge 7 commits into
Open
Conversation
stephanos
commented
Jun 11, 2026
| func (s *taskQueueStatsContext) requireWDVTaskQueueStatsRelaxed( | ||
| ctx context.Context, | ||
| a *require.Assertions, | ||
| func (s *TaskQueueStatsVersionSuite) requireWDVTaskQueueStatsRelaxed( |
Contributor
Author
There was a problem hiding this comment.
These helpers were moved from the env/ctx to the suite to make assertions easier and fit into the style of the other suites.
long-nt-tran
approved these changes
Jun 11, 2026
long-nt-tran
left a comment
long-nt-tran
left a comment
Contributor
There was a problem hiding this comment.
LGTM, seems CI failure will be fixed with #10665 -- sorry missed that in the original migration PR review
Contributor
There was a problem hiding this comment.
I also see some usage of context.Background() instead of s.Context() which could help w/ making test timeouts more stable, we can fix in subsequent PR (not blocking this PR since name suggests we're scoping it tighter, feel free to fix here or later
Contributor
Author
There was a problem hiding this comment.
Good catch; let me update that, too!
stephanos
force-pushed
the
stephanos/task-queue-stats-await
branch
from
0f60ba7 to
1100257
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed?
Use
Await.Why?
Test stability;
Awaitwill gain adaptive test timeout and this PR fails without it then.