Skip to content

Port v1.23.0-rc16 scheduler workflow into current package#10650

Draft
hehaifengcn wants to merge 1 commit into
cloud/v1.32.0-155from
haifeng/schedule-v1.23.0-rc16
Draft

Port v1.23.0-rc16 scheduler workflow into current package#10650
hehaifengcn wants to merge 1 commit into
cloud/v1.32.0-155from
haifeng/schedule-v1.23.0-rc16

Conversation

@hehaifengcn

Copy link
Copy Markdown
Contributor

Replace the scheduler workflow implementation with the v1.23.0-rc16 logic
while reusing the current package's compatible siblings (spec.go, buffer.go,
calendar.go, activities.go, fx.go, query.go).

Adaptations to the rc16 workflow:

  • searchattribute.* -> sadefs.* (constants moved between 1.23 and 1.31)
  • NewCompiledSpec -> specBuilder.NewCompiledSpec; getNextTime/getNextTimeResult
    -> GetNextTime/GetNextTimeResult; processBuffer -> ProcessBuffer with exported
    result fields
  • defaultLocalActivityOptions var -> func() to match current activities.go

Preserved exports so the rest of the server still builds:

  • schedulerWorkflowWithSpecBuilder (4-arg) and GetListInfoFromStartArgs (3-arg)
  • SignalNameMigrateToChasm (ignored by v1.23 logic) and CurrentTweakablePolicies
    with a kept-for-compat SpecFieldLengthLimit field

Full production build (go build ./...) passes.

Co-Authored-By: Claude Opus 4.8 (1M context) noreply@anthropic.com

What changed?

Describe what has changed in this PR.

Why?

Tell your future self why have you made these changes.

How did you test it?

  • built
  • run locally and tested manually
  • covered by existing tests
  • added new unit test(s)
  • added new functional test(s)

Potential risks

Any change is risky. Identify all risks you are aware of. If none, remove this section.

Replace the scheduler workflow implementation with the v1.23.0-rc16 logic
while reusing the current package's compatible siblings (spec.go, buffer.go,
calendar.go, activities.go, fx.go, query.go).

Adaptations to the rc16 workflow:
- searchattribute.* -> sadefs.* (constants moved between 1.23 and 1.31)
- NewCompiledSpec -> specBuilder.NewCompiledSpec; getNextTime/getNextTimeResult
  -> GetNextTime/GetNextTimeResult; processBuffer -> ProcessBuffer with exported
  result fields
- defaultLocalActivityOptions var -> func() to match current activities.go

Preserved exports so the rest of the server still builds:
- schedulerWorkflowWithSpecBuilder (4-arg) and GetListInfoFromStartArgs (3-arg)
- SignalNameMigrateToChasm (ignored by v1.23 logic) and CurrentTweakablePolicies
  with a kept-for-compat SpecFieldLengthLimit field

Full production build (go build ./...) passes.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant