config: parse default mkosi-tools and mkosi-initrd before parsing use… - #4367
Closed
behrmann wants to merge 1 commit into
Closed
config: parse default mkosi-tools and mkosi-initrd before parsing use…#4367behrmann wants to merge 1 commit into
behrmann wants to merge 1 commit into
Conversation
…r config
In finalize_default_tools and finalize_default_initrd mkosi-tools and
mkosi-initrd were parsed last respectively, that is after parsing config from
the CLI, mkosi.conf, and mkosi.{tools,initrd}.conf.
When trying to add buildstream as a supported distribution, setting an empty
packages list in the mkosi-initrd resources, would then overwrite all initrd
packages, so that none could be set. A similar problem would be encountered for
tools trees.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…r config
In finalize_default_tools and finalize_default_initrd mkosi-tools and mkosi-initrd were parsed last respectively, that is after parsing config from the CLI, mkosi.conf, and mkosi.{tools,initrd}.conf.
When trying to add buildstream as a supported distribution, setting an empty packages list in the mkosi-initrd resources, would then overwrite all initrd packages, so that none could be set. A similar problem would be encountered for tools trees.