Pass in target obj instead of string targetName#10154
Open
thePianoKid wants to merge 1 commit into
Open
Conversation
thePianoKid
requested review from
bkhouri,
bripeticca,
cmcgee1024,
daveinglis,
daveyc123,
dschaefer2,
jakepetroules,
owenv,
plemarquand and
rconnell9
as code owners
thePianoKid
changed the title
bkhouri
approved these changes
Jun 1, 2026
Contributor
|
@swift-ci test |
1 similar comment
Contributor
Author
|
@swift-ci test |
Contributor
Author
|
@swift-ci test linux |
Contributor
Author
|
@swift-ci test macOS |
thePianoKid
force-pushed
the
thePianoKid/use-target-obj
branch
from
3e5c9d2 to
2abdcdf
Compare
Contributor
Author
|
I closed #10152, so this PR is no longer blocked. It doesn't need to get into 6.4 since this is purely a quality of life change. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation:
Use type-checking so that only target objects can be passed in to a
BinaryArtifactsManagerError.The diff is muddy because this PR is blocked by #10152.