feat(java): bundle per-section dialect fixtures in the extensions artifact - #49
Merged
Merged
Conversation
…ifact The extensions artifact bundles the spec's extension YAMLs, text schemas and function test-case files as classpath resources under `substrait/`, but not the per-section dialect fixtures (`substrait/dialects/tests/*_test.yaml`). Add them so downstream consumers can load those fixtures from the artifact rather than from a spec checkout. This lets substrait-java drop its `substrait` git submodule: it currently reads these fixtures from the submodule working tree, and this is the last spec resource it needs that the extensions artifact does not yet ship.
andrew-coleman
approved these changes
Jul 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
The
extensionsartifact bundles the spec's extension YAMLs, text schemas and function test-case files as classpath resources undersubstrait/, but not the per-section dialect fixtures. This adds them:so the artifact ships
substrait/dialects/tests/{types,relations,expressions,functions,execution_behavior}_test.yamlalongside the resources it already carries.Why
substrait-javastill keeps the upstream spec as asubstraitgit submodule solely to read a handful of resources at build/test time. It already sources proto, ANTLR and extension YAMLs from these packaging artifacts; the per-section dialect fixtures are the last spec resource it reads directly from the submodule working tree. Shipping them here lets substrait-java drop the submodule entirely and source the whole spec from published artifacts.Validation
ci_java.ymlattaches the spec subtree and runs:extensions:build, so the new glob is exercised on this PR.dialects/tests/*_test.yamlfixtures; substrait-java's full reactor build then passes against it with the submodule removed.🤖 Generated with AI