feat(extensions): resolve UDT URNs while parsing - #253
Draft
benbellick wants to merge 4 commits into
Draft
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #253 +/- ##
==========================================
+ Coverage 68.95% 69.02% +0.07%
==========================================
Files 47 47
Lines 10935 10984 +49
==========================================
+ Hits 7540 7582 +42
- Misses 3034 3039 +5
- Partials 361 363 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Draft alternative to the stacked dependency/UDT validation work.
This explores resolving user-defined type references while parsing extension YAML type expressions instead of constructing unresolved
u!namenodes and inferring their URN later from the function variant.Key changes:
UserDefinedTypeResolvertypes.ParameterizedUserDefinedTypeurnandtypes:declarationsThis intentionally starts with local UDT resolution. Dependency-qualified references can build on the same resolver shape by resolving aliases to dependency URNs.
Tests:
go test ./...Note: This PR was developed with AI assistance. All changes have been reviewed, and I take full responsibility for this contribution.