Skip to content

feat: Add bail to MTP test runner#3674

Draft
richardwerkman wants to merge 5 commits into
masterfrom
feature/mtp-performance-2
Draft

feat: Add bail to MTP test runner#3674
richardwerkman wants to merge 5 commits into
masterfrom
feature/mtp-performance-2

Conversation

@richardwerkman

@richardwerkman richardwerkman commented Jun 29, 2026

Copy link
Copy Markdown
Member

closes #3655 and #3675

  • Set MinVerSkip to true for improved compatibility.
  • Send cancel RPC command when the first test failure result is received.

On first inspection this feature doesn't seem to do much on smaller projects. The tests are done before the cancel testrun command is received through RPC.

todo:

  • Test on a larger project if the testrun actually cancels when the command is received, polly could be a good candidate

Copilot AI review requested due to automatic review settings June 29, 2026 06:39

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

string SolutionPath { get; init; }
string SourceProjectName { get; init; }
string TargetFramework { get; init; }
string TestCaseFilter { get; init; }

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Check if these options aren't used from the interface

Copilot AI review requested due to automatic review settings June 29, 2026 16:37

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@sonarqubecloud

Copy link
Copy Markdown

Quality Gate Failed Quality Gate failed

Failed conditions
77.1% Coverage on New Code (required ≥ 80%)
1 New Critical Issues (required ≤ 0)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

MTP stop testrun (bail) on first test failure

2 participants