introduce shared modules to bitcoin_core_sv2#602
Merged
Shourya742 merged 6 commits intoJul 14, 2026
Merged
Conversation
plebhash
force-pushed
the
2026-07-07-bitcoin-core-sv2-shared-modules
branch
from
July 7, 2026 23:48
6575eee to
1862daa
Compare
Contributor
plebhash
force-pushed
the
2026-07-07-bitcoin-core-sv2-shared-modules
branch
2 times, most recently
from
July 9, 2026 17:54
8906f16 to
d91e829
Compare
plebhash
marked this pull request as ready for review
July 9, 2026 17:54
Member
Author
|
ready for review |
plebhash
force-pushed
the
2026-07-07-bitcoin-core-sv2-shared-modules
branch
from
July 9, 2026 20:34
d91e829 to
e957cc5
Compare
plebhash
force-pushed
the
2026-07-07-bitcoin-core-sv2-shared-modules
branch
from
July 9, 2026 20:37
e957cc5 to
3f62871
Compare
github-project-automation
Bot
moved this to Todo 📝
in Stratum V2 - 2026 Q3 - Roadmap 📍🗺️
GitGab19
moved this from Todo 📝
to Ready For Review 🔍
in Stratum V2 - 2026 Q3 - Roadmap 📍🗺️
GitGab19
reviewed
Jul 10, 2026
Shourya742
self-requested a review
July 10, 2026 13:57
GitGab19
approved these changes
Jul 10, 2026
Shourya742
reviewed
Jul 13, 2026
plebhash
force-pushed
the
2026-07-07-bitcoin-core-sv2-shared-modules
branch
from
July 13, 2026 14:56
3f62871 to
0ac999d
Compare
plebhash
force-pushed
the
2026-07-07-bitcoin-core-sv2-shared-modules
branch
from
July 13, 2026 16:28
0ac999d to
a942d6f
Compare
This was referenced Jul 16, 2026
plebhash
added a commit
to plebhash/sv2-apps
that referenced
this pull request
Jul 21, 2026
reverts the shared-modules direction of stratum-mining#602 (stratum-mining#574) for the JDP mempool module, per the discussion on stratum-mining#619: the shared v31x_v30x module does not scale well (forced #[path] includes, confusing navigation), so we prefer explicit per-version duplication until genuinely common abstractions are better understood. v30x and v31x now each carry their own copy of mempool.rs (identical except the header comment). the v31x_v30x module scaffolding is removed; the remaining template_distribution_protocol/monitors.rs file stays at its current path as a #[path] include target until the next commit. also fixes stale rustdoc links in the JDP mod.rs doc comments left over from the common -> runtime_api rename (stratum-mining#602). no public API changes: v31x_v30x was pub(crate), runtime_api is kept.
plebhash
added a commit
to plebhash/sv2-apps
that referenced
this pull request
Jul 21, 2026
reverts the shared-modules direction of stratum-mining#602 (stratum-mining#574) for the TDP monitor loop, per the discussion on stratum-mining#619 (see previous commit for rationale). v30x and v31x now each carry their own copy of monitors.rs as a regular child module; no more #[path] includes or clippy::duplicate_mod allows. the v31x_v30x directory is gone for good. both copies preserve the post-stratum-mining#602 evolution of the shared file (waitNext fee_threshold/timeout parameterization with MAX_MONEY throttling, and the process_stale_template_data snapshot refactor). no public API changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
close #574