refactor: rewrite in Rust for performance#20
Open
adthrasher wants to merge 11 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an initial implementation in Rust. When running a sample through, I get a perfect match for the
downstreamsubset of GFF features.When looking at the
genebody, there are some differences, but at least some are due to the original Python implementation being flawed (See #83 and #84 for examples).Ultimately, there are some ugly Rust pieces in this, trying to perfectly match the output formatting from Python. These can be improved. We can also drop any of the non-matrix functionality, since that isn't used in SEAseq/PEAseq. The biggest takeaway is that this runs in less than 10 minutes for each feature type, whereas the corresponding Python implementation took 2-20 hours depending on the feature type.
I have included the outputs from the
bamtogff_plottask using the Python matrices and the Rust matrices for comparison.python.tar.gz
rust.tar.gz